From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A4D271 for ; Tue, 13 Apr 2021 03:59:32 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id lr1-20020a17090b4b81b02900ea0a3f38c1so652938pjb.0 for ; Mon, 12 Apr 2021 20:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=MMUmn5mABVsgrfWlibL4nmwnAT3Kpef8pz6y5TktZjk=; b=Ys9jkndzAW5uBB7GfhA/tsOayE/UE2BtjjEmlkCxMxIaFyKY9MFSTgxpxWfdxDk5h6 4GWMRa1At+rbawl7r+Z1ypxff05XvHVP6FJk0rUwuZvpu7oHxR+zRcgQTNvQ5c0zIaDl 8zGjUvzQzTebIuUXkQQJtgi2n3hrI2nMtG7ol1GcxV4Yi5T7hMrrLyU/uTne4QGBGugO m3Y2Ytu/ygqr53ax/sTz7JOBmqyJGoeegcv3N/XzUsjXfVnMz7S+aEA98LgmOUO/mHrP LcQuUXLYbgSbQ+lkHAY2DGQLleHBdh18anpWTWfuYc2fxLb5YxO77/JoFn32/4foikjV 4yJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=MMUmn5mABVsgrfWlibL4nmwnAT3Kpef8pz6y5TktZjk=; b=OEb7LZg+nuQjBPHEphTOt1C0g6FcP02EUmowmpktvY0VgslFqmCl7p1YeC3+Z/3hc3 nHQc6MnPFuRGdKBVGN1RQhdmGXdmjlvtwkhecC3mTjN928tVhJjYMz7sgYbCUxqA2Aq4 S/WzaeF6b033jCaqx2xOjNjPjr1gh+m1BZa+e7YiJxo4Zf6clKHyGvSe+l8FN8eCINlb lMRahHGl8qITaM0lzxtYWkcSurBlovvcVgR+MldeG7zl543ESzQIsLCYPJt1VCnlZZRU gjaAu1qIG1n5OpS0MF2coO60tv1fMM7VqqoN8P8hW+QUp4DSUGlb3JgYO+HD/Pmr1GmA xx1A== X-Gm-Message-State: AOAM532rij6lPDEE8kckL6REKHc7bzGB6MCZAEvoZ1Te46Eqfj3uDXnK 2AYRK1en5Zo742vXDp4/DSI= X-Google-Smtp-Source: ABdhPJyMRWGljYt/4aZ19IQ3gt9VmDkMZt1nOhw1lL4WoWV67sNLFAuRj0SR3TADUx1CDcAdnktDiQ== X-Received: by 2002:a17:90a:7bce:: with SMTP id d14mr2751340pjl.139.1618286371967; Mon, 12 Apr 2021 20:59:31 -0700 (PDT) Received: from localhost.localdomain ([138.197.212.246]) by smtp.gmail.com with ESMTPSA id 67sm11110165pfy.140.2021.04.12.20.59.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 20:59:31 -0700 (PDT) From: DENG Qingfang To: =?iso-8859-1?Q?Ren=E9?= van Dorst Cc: "David S. Miller" , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Jakub Kicinski , Landen Chao , Matthias Brugger , Russell King , Sean Wang , Vivien Didelot , Vladimir Oltean , Rob Herring , Linus Walleij , Greg Kroah-Hartman , Sergio Paracuellos , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-staging@lists.linux.dev, devicetree@vger.kernel.org, netdev@vger.kernel.org, Weijie Gao , Chuanhong Guo , Frank Wunderlich , Thomas Gleixner , Marc Zyngier Subject: Re: [RFC v4 net-next 1/4] net: phy: add MediaTek PHY driver Date: Tue, 13 Apr 2021 11:59:20 +0800 Message-Id: <20210413035920.1422364-1-dqfext@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210412150836.929610-1-dqfext@gmail.com> References: <20210412034237.2473017-1-dqfext@gmail.com> <20210412034237.2473017-2-dqfext@gmail.com> <20210412070449.Horde.wg9CWXW8V9o0P-heKYtQpVh@www.vdorst.com> <20210412150836.929610-1-dqfext@gmail.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Apr 12, 2021 at 11:08:36PM +0800, DENG Qingfang wrote: > On Mon, Apr 12, 2021 at 07:04:49AM +0000, René van Dorst wrote: > > Hi Qingfang, > > > +static void mtk_phy_config_init(struct phy_device *phydev) > > > +{ > > > + /* Disable EEE */ > > > + phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_EEE_ADV, 0); > > > > For my EEE patch I changed this line to: > > > > genphy_config_eee_advert(phydev); > > > > So PHY EEE part is setup properly at boot, instead enable it manual via > > ethtool. > > This function also takes the DTS parameters "eee-broken-xxxx" in to account > > while > > setting-up the PHY. > > Thanks, I'm now testing with it. Hi Rene, Within 12 hours, I got some spontaneous link down/ups when EEE is enabled: [16334.236233] mt7530 mdio-bus:1f wan: Link is Down [16334.241340] br-lan: port 3(wan) entered disabled state [16337.355988] mt7530 mdio-bus:1f wan: Link is Up - 1Gbps/Full - flow control rx/tx [16337.363468] br-lan: port 3(wan) entered blocking state [16337.368638] br-lan: port 3(wan) entered forwarding state The cable is a 30m Cat.6 and never has such issue when EEE is disabled. Perhaps WAKEUP_TIME_1000/100 or some PHY registers need to be fine-tuned, but for now I think it should be disabled by default. > > > > > > + > > > + /* Enable HW auto downshift */ > > > + phy_modify_paged(phydev, MTK_PHY_PAGE_EXTENDED, 0x14, 0, BIT(4));