From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: media: atomisp: pci: Format multi-line comments according to coding-style in file atomisp_cmd.c
Date: Wed, 14 Apr 2021 21:33:25 +0300 [thread overview]
Message-ID: <20210414183325.GD3@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20210414182755.GA2799@focaruja>
Hi Aline,
Thanks for the patch.
On Wed, Apr 14, 2021 at 03:27:55PM -0300, Aline Santana Cordeiro wrote:
> Format multi-line comments according to the coding-style.
> Issue detected by checkpatch.pl.
>
> Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
> ---
> drivers/staging/media/atomisp/pci/atomisp_cmd.c | 109 ++++++++++++++----------
> 1 file changed, 65 insertions(+), 44 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> index 592ea99..6113785 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> @@ -67,7 +67,8 @@
> * At 15fps this means 133ms. We set the timeout a bit longer.
> * Each flash driver is supposed to set its own timeout, but
> * just in case someone else changed the timeout, we set it
> - * here to make sure we don't damage the flash hardware. */
> + * here to make sure we don't damage the flash hardware.
> + */
> #define FLASH_TIMEOUT 800 /* ms */
>
> union host {
> @@ -562,7 +563,8 @@ irqreturn_t atomisp_isr(int irq, void *dev)
> * and driver needs to keep old sequence_temp value.
> * NOTE: There is assumption here that ISP will not
> * start processing next frame from sensor before old
> - * one is completely done. */
> + * one is completely done.
> + */
> if (atomic_read(&asd->sequence) == atomic_read(
> &asd->sequence_temp))
> atomic_set(&asd->sequence_temp,
> @@ -1247,7 +1249,8 @@ void atomisp_buf_done(struct atomisp_sub_device *asd, int error,
>
> if (IS_ISP2401) {
> /* If there are no buffers queued then
This should begin with:
/*
*
And the same for the rest. Apart from this the patch seems fine.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2021-04-14 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 18:27 [PATCH] staging: media: atomisp: pci: Format multi-line comments according to coding-style in file atomisp_cmd.c Aline Santana Cordeiro
2021-04-14 18:33 ` Sakari Ailus [this message]
2021-04-14 18:55 ` ascordeiro
2021-04-14 20:06 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414183325.GD3@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=alinesantanacordeiro@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox