From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7272F71 for ; Tue, 20 Apr 2021 08:35:28 +0000 (UTC) Received: by mail-ed1-f52.google.com with SMTP id e7so43920538edu.10 for ; Tue, 20 Apr 2021 01:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=i+wMprnsuXena69+qMh8afYKa3tm2MfcxOqLgpl/V+M=; b=iD4dGt+vZnDr55oT9LltKrw1nN6ttT3jJxy4S5KEYsy3JBI3vgxwU7WyYdqdc1gY0E YjnUa2G9MF1WxpcG+9eAPw2S25mkaj+8RuCz44331k29rieCbWcHBotyjwiciDzyBClz KSlP5t+Kwtozo5RVOpW7oF6jwu/jT8k1hzOTec3XxsjwFha6NrZv9QUtkFDv943e/7rZ Pznc7GM1vvl14EGt2/lzI5I66rNzzGfHxd51iFIAc7crvPMQI+FvR+ZFwm2CUGMqSceC ihFsN4kmald856M+8+40qxk7KheL2QipE2F9u5CWuHgeCX8ptUAjenQb+nP9hY07mH1j e/RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=i+wMprnsuXena69+qMh8afYKa3tm2MfcxOqLgpl/V+M=; b=VglyvRSJ5kttMtf7MI/rsWA8h8xnAnTfKrQhPmJmMr67yaGijFFo0iq9gcTFb9jSdR 2eNyxA+CqB5FHbbJ/KGTXfDur5QAjJnmTB0wCGc4vrXim2GWdl2taTEqjps87Y/45Av/ X+xRPPBzPZAPiqIpuFBO04UPbsKwavCMBYO6gJxzn3Imb5C+oADMuDxnCJ2AJGEQqcSN AF5MSdp5vucfjsEPIddcX3IioBfTF8EevMquYf5qmChjfmgb9OdUaTe96RWgrU8DTC1M xc/7JeMWx6hpqEPXhS+mIKkys+2gcGD577kx52HKF8K+2feJ3QKAVWYla9zTjjkPgyzE rJBw== X-Gm-Message-State: AOAM532/zMOgIpFjEr8dPp7kDy6ymwMnNOED3O/tNTWYeqw6gM0ITqp6 /OoMFOY6Y0yFG4iGJk+iY6o= X-Google-Smtp-Source: ABdhPJwxO0AX/91okpE9i7ZBRmIZCORhyRnMeuV1WKhZLpUqkO//V69bgRiHj45u0Wl0q0Z3DjfjBw== X-Received: by 2002:aa7:c3c7:: with SMTP id l7mr18049729edr.199.1618907727004; Tue, 20 Apr 2021 01:35:27 -0700 (PDT) Received: from agape.jhs ([5.171.72.235]) by smtp.gmail.com with ESMTPSA id u24sm14860565edt.85.2021.04.20.01.35.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Apr 2021 01:35:26 -0700 (PDT) Date: Tue, 20 Apr 2021 10:35:23 +0200 From: Fabio Aiuto To: Deepak R Varma Cc: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] staging: media: atomisp: use printk with KERN facility level Message-ID: <20210420083522.GA1411@agape.jhs> References: <4947abeebc2cecca43137675519a2fb48577d3e5.1618859059.git.drv@mailo.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4947abeebc2cecca43137675519a2fb48577d3e5.1618859059.git.drv@mailo.com> User-Agent: Mutt/1.10.1 (2018-07-13) Hi Deepak, On Tue, Apr 20, 2021 at 12:46:40AM +0530, Deepak R Varma wrote: > printk() without KERN_ facility is flagged by checkpatch as a > warning. It is better to use pr_info() which comes with an > inbuilt KERN_INFO level. > > Signed-off-by: Deepak R Varma > --- > drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c > index b572551f1a0d..a0f3c5c32f94 100644 > --- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c > +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c > @@ -1020,7 +1020,7 @@ static int gc0310_set_fmt(struct v4l2_subdev *sd, > return -EINVAL; > } > > - printk("%s: before gc0310_write_reg_array %s\n", __func__, > + pr_info("%s: before gc0310_write_reg_array %s\n", __func__, > gc0310_res[dev->fmt_idx].desc); in a driver is best recommended to replace a raw printk call with a dev_*() log. Check few lines above here to see how it is done. > ret = startup(sd); > if (ret) { > -- > 2.25.1 > > thank you, fabio