From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Deepak R Varma <drv@mailo.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, mh12gx2825@gmail.com
Subject: Re: [PATCH] staging: media: atomisp: replace pr_info() by dev_info()
Date: Thu, 22 Apr 2021 15:43:04 +0200 [thread overview]
Message-ID: <20210422134302.GA1388@agape.jhs> (raw)
In-Reply-To: <20210422103037.GA239298@localhost>
On Thu, Apr 22, 2021 at 04:00:37PM +0530, Deepak R Varma wrote:
> It is recommended to use driver model diagnostic macros dev_*() instead
> of pr_*() since the former ensures that the log messages are always
> associated with the corresponding device and driver.
>
> Suggested-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
>
> Note: There are few more pr_into() calls that I have not replaced since
> they are very basic (entry and exit) and temporary. They can be removed
> if the APIs are fully tested. See this example:
> pr_info("%s S\n", __func__);
>
> Let me know if I should remove them and resubmit this patch.
>
Hi Deepak,
usually log functions saying "we are here in the code" are not needed,
ftrace is designed for function tracing and other useful things.
I think this patch is aimed for substitution which is logically
different from deletion of function calls.
pr_info deletions can be provided in a separate patch.
Thank you,
fabio
next prev parent reply other threads:[~2021-04-22 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 10:30 [PATCH] staging: media: atomisp: replace pr_info() by dev_info() Deepak R Varma
2021-04-22 13:43 ` Fabio Aiuto [this message]
2021-04-23 9:14 ` Hans Verkuil
2021-04-23 16:47 ` Deepak R Varma
2021-04-26 9:21 ` Sakari Ailus
2021-04-26 14:23 ` Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210422134302.GA1388@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mh12gx2825@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox