From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A68912F9B for ; Thu, 22 Apr 2021 13:43:09 +0000 (UTC) Received: by mail-ed1-f48.google.com with SMTP id i3so27829620edt.1 for ; Thu, 22 Apr 2021 06:43:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/X+gdpa7nitmW2LfUzsCx+59dgi99zMR2DugLsgYeVY=; b=r6lLcdebfCTFu2pd9lwHbs5JefCnwomGDE9DWqi02d0FlvcgrAdgFei4gyN/l4l3DM Z6UveAIULr/vdBT1XOOYKMn0ZLPA9ndTj456Va2XnM0COfIaYdof/AOGH++/PYKX96QX lMtucwWwqedRrVOfMxMrOCTY6alMO1JvDK5da0gX4iYmuFGpUj1va5GWG4ukBwMgCj6l +td0fxi3r2K8ICwb1k+L80907KZPKnksmc/r3Zc2nU1rx+uF5PkNsX61BtsFkuaIOlWZ NZawvZ1qXxpQfV8j/+36qIMqUSUbTKe4BTrnhzsVH5rNSjX2bjaoXxRe5s/YRNfKdCYi /fbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/X+gdpa7nitmW2LfUzsCx+59dgi99zMR2DugLsgYeVY=; b=uEoopwYYTiBZY0bDGQ/YqVajDdX/x+cR1/pyYMx1k0ILGJbXZkr24bAS5F7z1YbctZ oWt8KeAeURkRHaPlnAbosK908DC5spqlTF1+F6dBT6xaH0imZFcFXc9GNgPT8ZuE765Q Oux417OhSiZLjoDCEc9YKCvFBnvQaxgRtpyfPLNd6y3KdsE8ZUkrA241mqD8EEGPTWCY xtVXCMvwA+IwxFExxl6v2HgX9Va7G10Ws4LrbjAmYXy6pUWs/pIeCNxxipNtk3PoIPVJ nQLYvxF+wvMubQOty2c08ywZSSHE24d3cI83D3seHslSh+eIdLJT9dHavpXQISnJt6fF jGtQ== X-Gm-Message-State: AOAM5328bvbkgLIGNtcDFsRt8nDapT2J/39l7MlWA1vRpPFsOmzWSJ3V 4Tjt55kLsWOwnhWi5JAySBs= X-Google-Smtp-Source: ABdhPJxni7A19BFMdj/QOaNYmYXKzoN9GGJkUu7R1VHY8fFW0VN7v9e3beuiEtbxdpyntwIAaKM2TQ== X-Received: by 2002:a05:6402:4314:: with SMTP id m20mr3862131edc.5.1619098988214; Thu, 22 Apr 2021 06:43:08 -0700 (PDT) Received: from agape.jhs (na-19-64-241.service.infuturo.it. [151.19.64.241]) by smtp.gmail.com with ESMTPSA id hg19sm1931269ejc.24.2021.04.22.06.43.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Apr 2021 06:43:07 -0700 (PDT) Date: Thu, 22 Apr 2021 15:43:04 +0200 From: Fabio Aiuto To: Deepak R Varma Cc: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, mh12gx2825@gmail.com Subject: Re: [PATCH] staging: media: atomisp: replace pr_info() by dev_info() Message-ID: <20210422134302.GA1388@agape.jhs> References: <20210422103037.GA239298@localhost> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210422103037.GA239298@localhost> User-Agent: Mutt/1.10.1 (2018-07-13) On Thu, Apr 22, 2021 at 04:00:37PM +0530, Deepak R Varma wrote: > It is recommended to use driver model diagnostic macros dev_*() instead > of pr_*() since the former ensures that the log messages are always > associated with the corresponding device and driver. > > Suggested-by: Fabio Aiuto > Signed-off-by: Deepak R Varma > --- > > Note: There are few more pr_into() calls that I have not replaced since > they are very basic (entry and exit) and temporary. They can be removed > if the APIs are fully tested. See this example: > pr_info("%s S\n", __func__); > > Let me know if I should remove them and resubmit this patch. > Hi Deepak, usually log functions saying "we are here in the code" are not needed, ftrace is designed for function tracing and other useful things. I think this patch is aimed for substitution which is logically different from deletion of function calls. pr_info deletions can be provided in a separate patch. Thank you, fabio