From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4096B2FA5 for ; Tue, 27 Apr 2021 19:12:05 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id md17so4048429pjb.0 for ; Tue, 27 Apr 2021 12:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+SROfjuDf0LvnCgRM16+n6964r7e8cgU3/0ENTxesNQ=; b=lTEqBuj+nVbGPVu8/uF08bM5OB0fBAGKcFrX5ZyGjgnBpDwkl7BzvdT+RwRhGZzPfe RxU3qoJcWVbz4h1nM0Rnwqk3VOxuy1/DbkqCzudiATVfPiUxk6AdKXC23gW1aXwBT//D TGnQsjInr0CNB9kWpQs9CwVmyJniMH7SZpDa8lUKBJAgpSmt3+BVL/3ZMJh3eYrg+V2y AiggLKzxpiBb0GqiCzHcypwtg4GncxIppvkn1R3WFEHbdk6WxBJtKgyKFinuK73K67eE QS8jYYmG/+rhTqeKkuKF2EIqAjwHyd4IMOxAJ05kp+BzEJZbRX+RubssHw4bpVq3azjS eTog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+SROfjuDf0LvnCgRM16+n6964r7e8cgU3/0ENTxesNQ=; b=Oj+5eyuMXFtrX2YarWqxkkDpv0Mj7u8vScs7hwXKqlSVd2Gbs6Ns1VgvlomvmVpfYl SoW8wCLdcUm4iaBy7El4uXiNUOKVDcnQFnhRwpwnpmSkXqEinXZt6NUyYgaP//pdaDod 2txkEMA8dCBmYgXrW0Vw+3m08IeRMOwAxwpeU7vgj/nuCGf6LrM7FYb9GDvOxW1DQv3u 24vL0TEhzGAFejUoL+ubKzxaMSBg/fCN12C55jlcCGy67Q+U2kuAFE8YWftJZ37N9c9C WJSLDM+MNK49iRhMXfuPA6sxuhtvKemq2SUNbfRTbHUmzjCiI/LC5hMLXvfYzEYbTjIe dqZA== X-Gm-Message-State: AOAM533+RSaequvv4egHzmE2z7yDS+XxBAma4RGS9xOgImXTbOz6I/N7 Bvyri+zb3xbsavHoEXn/Rik= X-Google-Smtp-Source: ABdhPJzcStLi1h7eE+Z2wOdg2Jmaq3PfNgkRNJlHpssKF2f3V0yCK/CgtPVt68V+d5Ejs8lrEPZi9Q== X-Received: by 2002:a17:903:2288:b029:eb:6ca4:6493 with SMTP id b8-20020a1709032288b02900eb6ca46493mr26053305plh.85.1619550724769; Tue, 27 Apr 2021 12:12:04 -0700 (PDT) Received: from user ([2001:4490:4409:fe15:9fd0:fa2c:4efc:28b5]) by smtp.gmail.com with ESMTPSA id d1sm2790990pjs.12.2021.04.27.12.12.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 12:12:04 -0700 (PDT) Date: Wed, 28 Apr 2021 00:41:56 +0530 From: SAURAV GIREPUNJE To: Greg KH Cc: fabioaiuto83@gmail.com, john.oldman@polehill.co.uk, ross.schm.dev@gmail.com, marcocesati@gmail.com, insafonov@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com Subject: Re: [PATCH] staging: rtl8723bs: os_dep: remove unneeded variable ret Message-ID: <20210427191156.GA11046@user> References: <20210418164813.GA57451@user> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Apr 22, 2021 at 10:41:07AM +0200, Greg KH wrote: > On Sun, Apr 18, 2021 at 10:18:13PM +0530, Saurav Girepunje wrote: > > Fix the following coccicheck warning: > > > > drivers/staging/rtl8723bs/os_dep/os_intfs.c:1156:5-8: > > Unneeded variable: "ret". Return "0" on line 1199 > > > > Signed-off-by: Saurav Girepunje > > --- > > drivers/staging/rtl8723bs/os_dep/os_intfs.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c > > index 1f34cb2e367c..920ec25c9a4f 100644 > > --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c > > +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c > > @@ -1153,7 +1153,6 @@ int rtw_suspend_common(struct adapter *padapter) > > struct pwrctrl_priv *pwrpriv = dvobj_to_pwrctl(psdpriv); > > struct mlme_priv *pmlmepriv = &padapter->mlmepriv; > > > > - int ret = 0; > > unsigned long start_time = jiffies; > > > > DBG_871X_LEVEL(_drv_always_, " suspend start\n"); > > @@ -1196,7 +1195,7 @@ int rtw_suspend_common(struct adapter *padapter) > > > > exit: > > > > - return ret; > > + return 0; > > } > > > > static int rtw_resume_process_normal(struct adapter *padapter) > > -- > > 2.25.1 > > > > > > If this function can only ever return 0, why is it returning anything at > all? Please fix it up to not do that. > > thanks, > > greg k-h Yes,this function always return 0. Function return type could be change to void. I will send another patch.