From: Dan Carpenter <dan.carpenter@oracle.com>
To: Amos Gross <email@amosgross.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] Staging: rtl8723bs: rtw_xmit: fixed tabbing issue
Date: Thu, 29 Apr 2021 12:08:45 +0300 [thread overview]
Message-ID: <20210429090845.GX1981@kadam> (raw)
In-Reply-To: <YIAVfRxQ+XmKEf47@arch.localdomain>
On Wed, Apr 21, 2021 at 12:07:31PM +0000, Amos Gross wrote:
> Fixed warning from checkpatch for code block not being indented
> correctly.
>
> Signed-off-by: Amos Gross <email@amosgross.com>
This isn't a bug fix but I always like to see a Fixes tag for these or
some kind of explanation about why it's wrong in the first place. In
this case it's just that the indenting has never been correct since the
driver was first merged.
regards,
dan carpenter
prev parent reply other threads:[~2021-04-29 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 12:07 [PATCH] Staging: rtl8723bs: rtw_xmit: fixed tabbing issue Amos Gross
2021-04-29 9:08 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210429090845.GX1981@kadam \
--to=dan.carpenter@oracle.com \
--cc=email@amosgross.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox