From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E81C70 for ; Sun, 2 May 2021 17:49:14 +0000 (UTC) Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C52DA611C0; Sun, 2 May 2021 17:49:11 +0000 (UTC) Date: Sun, 2 May 2021 18:50:02 +0100 From: Jonathan Cameron To: Lucas Stankus Cc: lars@metafoo.de, Michael.Hennerich@analog.com, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 0/2] staging: iio: cdc: ad7746: add dt properties for capacitive channel setup Message-ID: <20210502185002.4c2faead@jic23-huawei> In-Reply-To: References: X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 1 May 2021 09:32:03 -0300 Lucas Stankus wrote: > This patch series aims to replace the platform_struct for the ad7746 driver > in favor of device tree bindings, creating the dt-binding documentation in > the process. > > Since the header file was only used to define the struct and the excitation > level values, it was possible to remove the file entirely. > > Changelog v2 -> v3: > - Add application reference note for the inverted EXCX dt bindings > - Replace macro with lookup table for setting the capacitive channel > excitation voltage > > Lucas Stankus (2): > dt-bindings: staging: iio: cdc: ad7746: add binding documentation for > AD7746 > staging: iio: cdc: ad7746: use dt for capacitive channel setup. Looks good to me. Thanks! Will leave time for Rob or anyone else to take a look etc before applying. If I seem to have lost it then feel free to give me a poke in a few weeks (it's happened a few times in the past :( Thanks, Jonathan > > .../bindings/iio/cdc/adi,ad7746.yaml | 77 +++++++++++++++++++ > drivers/staging/iio/cdc/ad7746.c | 54 ++++++++----- > drivers/staging/iio/cdc/ad7746.h | 28 ------- > 3 files changed, 110 insertions(+), 49 deletions(-) > create mode 100644 Documentation/devicetree/bindings/iio/cdc/adi,ad7746.yaml > delete mode 100644 drivers/staging/iio/cdc/ad7746.h >