From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF41271 for ; Mon, 3 May 2021 07:42:23 +0000 (UTC) Received: by mail-ej1-f44.google.com with SMTP id m12so6480723eja.2 for ; Mon, 03 May 2021 00:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LqHlFIPmIy5Y2GPoZMM4D4gWHV/H7PW4NUYS7qLOhnw=; b=UdSeCPDt3We7RwRVFupSdzP9ifzoXef1CfB5AzVXHF+ZU+BUfyjZWrRAx30bVN68a7 HbCmk0RYFb+7XnKxCCYjgzIpjWp71f4QHS3ceFlJY2dWjVJBtQs0fDKB70sXG7fqD8y8 pjeG4TOb62tMxx6o23FZLcLrTpwqrVdAK9TnbLn7mo7BLwPLuZW5g1lxVy1l/r7HSj24 lIb/O/DP++jLFIlA0ubUFIhhsPwZaAHSuHJVLo4cCXq8aRGPfDPovPLe1S39bFuC7vrr SWWBWyKjoC3JYrR01Onm+ts8bYt/vA39QlcPI0ER2ymeYcGqYeXJmA4Hf4JjeC+I18sV WvOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LqHlFIPmIy5Y2GPoZMM4D4gWHV/H7PW4NUYS7qLOhnw=; b=oS6TWmZrtKaYxXpHFA07p72Aof7n4HgWBTjCiyjTPldc1TClyeazMcrf79dAejaTBN ANYMpw6rC16hEJdvagwa/bCI4qYIUNIQpvVlLNCUmYdJovLJAF1y+/WhNuzaa+o4RxCN GzEjJxWiZr3dmkgMmV6jm0XfH1pOKu4wyJPS6VrEvhTpX1pk3qxAfmeAE8DzszLVdEnK okEx+urdRIHmwusfXkXpCCU4/auXticcU2GGhSifi7hA45Yw96eAUmCOftHNqI156f7A LETUPwzh6Mg7Jzqyw0Qr4kfRE4XyN1u/+gxN7LByFvZH/SMkv8UlKxHCzyBlJBQE98Ez sETw== X-Gm-Message-State: AOAM533AM4jSEKn9xgcU+t5TtU42cknYjM+taXhZBWjnav/8mHz2d56g lYLHfweCp1gLM2U8hMFDrBM= X-Google-Smtp-Source: ABdhPJyz3qtLFhc7LlfWEHR+4Fi4UL9VY3uRkcPUcSLJo7wKJt6V4t374Ixvx6xzf8b8Sb2XldZH2Q== X-Received: by 2002:a17:906:5203:: with SMTP id g3mr15079739ejm.95.1620027742314; Mon, 03 May 2021 00:42:22 -0700 (PDT) Received: from agape.jhs ([5.171.72.252]) by smtp.gmail.com with ESMTPSA id a24sm9912641edr.74.2021.05.03.00.42.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 00:42:22 -0700 (PDT) Date: Mon, 3 May 2021 09:42:18 +0200 From: Fabio Aiuto To: Dan Carpenter Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 02/43] staging: rtl8723bs: remove if-else blocks left empty by ODM_RT_TRACE deletion Message-ID: <20210503074217.GA1557@agape.jhs> References: <0e1196ebf56787f62dcbfbcba1fcbc2ed37a65ce.1619794331.git.fabioaiuto83@gmail.com> <20210503072710.GL1981@kadam> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210503072710.GL1981@kadam> User-Agent: Mutt/1.10.1 (2018-07-13) On Mon, May 03, 2021 at 10:27:11AM +0300, Dan Carpenter wrote: > On Fri, Apr 30, 2021 at 04:56:24PM +0200, Fabio Aiuto wrote: > > @@ -1533,13 +1529,10 @@ static void phy_IQCalibrate_8723B( > > result[t][6] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQK_A_2, bMaskDWord)&0x3FF0000)>>16; > > result[t][7] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_After_IQK_A_2, bMaskDWord)&0x3FF0000)>>16; > > break; > > - } else { > > } > > } > > > > /* Allen end */ > > This comment doesn't mean anything. It feels like it was supposed to > go with the code that you deleted so it should have been deleted as part > of deleting the empty block. But it's fine to me if you delete it in > a later patch. Hi Dan, ok I will. > > > - if (0x00 == PathBOK) { > > - } > > } > > > > /* Back to BB mode, load original value */ > > regards, > dan carpenter > thank you, fabio