From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FA7971 for ; Fri, 14 May 2021 08:39:01 +0000 (UTC) Received: by mail-ed1-f52.google.com with SMTP id s6so33785844edu.10 for ; Fri, 14 May 2021 01:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=6uA/UUkc0ViJ/2YRaUldx05MrsQE2UfYmoMseM3ZwZM=; b=ZK4hqy9lY4WOC7ITURSwXwumBMAF0mS4b8rWte1LIqOdoROqHS3jnN0ClnzNwL8+Vk 9LnXzZsgtmb5kcEwYUFimU5rDxwfqH18XCl2QFgdqy05uw824vl9eaTEO2OEqxNWGAnl I5lTIpcMYPgsEWa3SeUA8rmpGQb244riN6vNKtoP9C1elotQEMxJQ7CMUVPutYwsow4+ yGu3XxCIu6jYdCncsC5STa+WttgvhhBj0Odvs8PiqSAvHzwgnWk/Cw2woWne4S2O2zXo 8TQaQ1VMkzQexTJ4LBSug+QJT8vJnriE7pmXPTEzRwrUauX/oZYddTPObjYqCVrH8/K2 /rlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=6uA/UUkc0ViJ/2YRaUldx05MrsQE2UfYmoMseM3ZwZM=; b=EBkVs/P8nZxDGNDwsqFN/X+PXEcLiVHy+EWjRF0hCBamr+MQPumJ8JSH1cdpaYOdMi L4UH0yMLGDhpG4HF5eiOdFiDUq7bAXUseW0NRwl5diVU6CUaTbhvbT3QRp7ExDJ5Qo4P RcpJOLJLX7VZPyOEGlUoOSlpKb3zkyxULvp7ny8FZ8bhQ+43FpXBK3pRGjTEDW+zq6gs MuR8em1qAFsYW1awwJHT2SUbno8GnI2ocga1Eb7F7YBdRynx9OgktS+WYqyJquOVvC04 tm14TZ1uZ/hNtP//HyvsBlEQvQHcqE7O0rmAkaYYt2hRxR73NRC7YezQavVAf2DML20h i0nQ== X-Gm-Message-State: AOAM531J1LT1VzZia0sCx2PhOKG5X6Eaw/5VqXPHmX6LW+v7O0wdFhWj GCZ7LEM74Duc/IfVPC2Pn0Q= X-Google-Smtp-Source: ABdhPJwKaVtECdy7q5WpBFC70sl7tYtv+CfNLH+hxu/BPK5uwBP4JU6QC8oZTF7hKzh5G8ma1j/PRw== X-Received: by 2002:a05:6402:652:: with SMTP id u18mr54957386edx.388.1620981540181; Fri, 14 May 2021 01:39:00 -0700 (PDT) Received: from agape.jhs ([5.171.81.81]) by smtp.gmail.com with ESMTPSA id k5sm4552527edk.46.2021.05.14.01.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 May 2021 01:38:59 -0700 (PDT) Date: Fri, 14 May 2021 10:38:57 +0200 From: Fabio Aiuto To: gregkh@linuxfoundation.org, hdegoede@redhat.com, Larry.Finger@lwfinger.net Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: staging: rtl8723bs: questions on TODO list Message-ID: <20210514083856.GA13800@agape.jhs> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Hello all, I'd like to have some clarifications about rtl8723bs driver. In order to make this driver ready for moving out of staging I would like to know: - find and remove remaining code valid only for 5 GHz. Most of the obvious ones have been removed, but things like channel > 14 still exist. is it possible to remove all 5g code, even the one related to power regulation when on band 5g? As far as I know about this card is that it doesn't support 5g, so may I just delete all 5g code or there are some constraints I'd take care of? - find and remove any code for other chips that is left over Ok this seems clear, are there some suggestion to do it safely? - convert any remaining unusual variable types Ok (but feel free to suggest anything) - find codes that can use %pM and %Nph formatting Ok (but feel free to suggest anything) - checkpatch.pl fixes - most of the remaining ones are lines too long. Many of them will require refactoring Ok - merge Realtek's bugfixes and new features into the driver Please, can you explain what one could do that? - switch to use LIB80211 - switch to use MAC80211 I think I need a few details for these last points as well. Do you think that one will need real hardware to complete these tasks? I don't have rtl8723bs card at the moment, so I think I will focus on those TODO activities which don't need it. thank you in advance, fabio