Re: [PATCH 00/17] Add an experimental driver for Intel NUC leds

Greg KH
2021-05-17T09:08:56Z

On Mon, May 17, 2021 at 11:02:58AM +0200, Mauro Carvalho Chehab wrote:
> Em Mon, 17 May 2021 10:18:57 +0200
> Greg KH <gregkh@linuxfoundation.org> escreveu:
>
> > On Sun, May 16, 2021 at 12:53:28PM +0200, Mauro Carvalho Chehab wrote:
> > > Hi Greg,
> > >
> > > This series add support for the LEDs found at Intel NUCs since
> > > NUC version 6.
> > >
> > > On several NUC models, the function of the LEDs are programmable,
> > > which allow them to indicate several different hardware events.
> > >
> > > They can even be programmed to represent an userspace-driven event.
> > >
> > > Some models come with single colored or dual-colored LEDs, but
> > > high end models have RGB LEDs.
> > >
> > > Programming them can ether be done via BIOS or by the OS.
> > >
> > > There are 3 different API types, and there is already some OOT
> > > drivers that were written to support them, using procfs, each
> > > one using a different (and IMO confusing) API.
> > >
> > > After looking at the existing drivers and not liking the uAPI
> > > interfaces there, I opted to write a new driver from scratch,
> > > unifying support for all different versions and using sysfs
> > > via the leds class.
> >
> > Just do this the "right way" and not add it to staging first. Just use
> > the existing LED class apis and all should be fine, no need for doing
> > anything unusual here.
>
> I'm using the standard LED class already (but not triggers), and the
> standard WMI support.
>
> Still, this API is complex, as it controls the LED behavior even when
> the machine is suspended. I would feel more comfortable if the ABI
> is not set into a stone at the beginning.

code in drivers/staging/ does not mean that you can mess with the
userspace api at will. It still follows the same "rules" of any other
kernel code when it comes to that.

So just work with the LED developers to come to a valid api that works
properly within that framework please.

thanks,

greg k-h