Re: [PATCH 17/17] staging: nuc-led: update the TODOs

Mauro Carvalho Chehab
2021-05-17T09:12:12Z

Em Mon, 17 May 2021 10:57:49 +0200
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> escreveu:

> Em Mon, 17 May 2021 10:05:27 +0200
> Pavel Machek <pavel@ucw.cz> escreveu:

> > No. Take a look at triggers; for example hdd monitor should look very
> > much like existing disk trigger.

Btw, is there a way to trigger brightness?

When a LED is monitoring the power state, brightness should be
hidden, as, instead of a single brightness parameter, the device
will now have one brightness per different power state, e. g.:

When the LED indicator is measuring *Power State*, the following
parameters may be available:

================================= =======================================
Parameter Meaning
================================= =======================================
<power_state>_brightness Brightness in percent (from 0 to 100)
<power_state>_blink_behavior type of blink.
See :ref:`nuc_blink_behavior`.
<power_state>_blink_frequency Blink frequency.
See :ref:`nuc_blink_behavior`.
<power_state>_color LED color
See :ref:`nuc_color`.
================================= =======================================

Where <power_state> is different, depending on the WMI API version:

On version 0.64 (NUC8/9):

+------------+
| s0 |
+------------+
| s3 |
+------------+
| s5 |
+------------+
| ready_mode |
+------------+

Btw, I've no idea what "ready mode" is, as the specs don't explain it.
This particular mode is disabled on my NUC8 device, so I can't test it.

On version 1.0 (NUC10+):

+------------+
| s0 |
+------------+
| s3 |
+------------+
| standby |
+------------+

Note: At the specs, "Standby" is actually "Modern Standby". I ended
simplifying it, as just "standby_brightness" sounds good enough.

Thanks,
Mauro