Re: [PATCH 01/17] staging: add support for NUC WMI LEDs

Greg KH
2021-05-17T08:20:04Z

On Sun, May 16, 2021 at 12:53:29PM +0200, Mauro Carvalho Chehab wrote:
> Some Intel Next Unit of Computing (NUC) machines have
> software-configured LEDs that can be used to display a
> variety of events:
>
> - Power State
> - HDD Activity
> - Ethernet
> - WiFi
> - Power Limit

<snip>

One nit:

> +static void nuc_wmi_remove(struct wmi_device *wdev)
> +{
> + struct device *dev = &wdev->dev;
> +
> + dev_info(dev, "NUC WMI driver removed.\n");
> +}

Drivers, when working properly, should be quiet. No need for noisy
stuff like this, it just slows down booting/loading for everyone.

thanks,

greg k-h