Re: [PATCH 01/17] staging: add support for NUC WMI LEDs

Randy Dunlap
2021-05-16T16:12:14Z

Hi Mauro,

On 5/16/21 3:53 AM, Mauro Carvalho Chehab wrote:
> diff --git a/drivers/staging/nuc-led/Kconfig b/drivers/staging/nuc-led/Kconfig
> new file mode 100644
> index 000000000000..0f870f45bf44
> --- /dev/null
> +++ b/drivers/staging/nuc-led/Kconfig
> @@ -0,0 +1,11 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +config LEDS_NUC_WMI
> + tristate "Intel NUC WMI support for LEDs"
> + depends on LEDS_CLASS
> + depends on ACPI_WMI
> + help
> + Enable this to support the Intel NUC WMI support for

Don't use "support" 2 times. Maybe:

Enable this to support the Intel NUC WMI interface for
or
Enable this to build the Intel NUC WMI support for

> + LEDs, starting from NUCi8 and upper devices.

Does "upper" mean "later"? Or more advanced? Not clear.

> +
> + To compile this driver as a module, choose M here.

thanks.
--
~Randy