From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DBBA2FB6 for ; Tue, 18 May 2021 04:42:59 +0000 (UTC) Received: by mail-pl1-f178.google.com with SMTP id h7so4406459plt.1 for ; Mon, 17 May 2021 21:42:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6/E0260RKAaTuA5t/VJ380T71hV58i1T3oQ6tmg0Xxg=; b=ktivBHXXlh0cPeILEDATbuupODCuGEWvSCydB3kAIJyY9rFtwRqyF0c4p5JRRF4vr8 rr4tast23bJ0v7lZ0I9IuqeBLvmdi6Xw4yxk5lMQq/cfLxZr4P9ixOac96saL+Xr/bzD TWKH19Nd/xFjvBo0PbNf1AJCRyf8DSlumkLlWQ9gSY2HDEi31Ec8yNF1P1raIdgO8VXA UJZ//D08SuF3VVX8jOAyMflfSL8C+LW3DeqK0fVdGsI8wvlF3lKX+VUuMsJigDXwtFwo MxTVLiLmmsxj4TyVDUjAr6OR/jj8NtuNEwgHiLzEpeL8kpISNy7+Qt5UaV5sbjsRf72o 63sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6/E0260RKAaTuA5t/VJ380T71hV58i1T3oQ6tmg0Xxg=; b=j7IuTnWihYgpdEPPWrK0GILf38uMyVB7ELhpbDM1gi/LYrn+It0SXqCtK7eKqI3o6p ohfLeK1oi1OMcjVuHEE6fT1xstUk6HUJtWMa0qHGBTM4F5L1kf33YAEWffgZwxOa7Xw2 uOQuW3ULCjZz1SGj4q7d7mG3HvIsW8Ojedij3HXR44gMJKg4C73jwK152cr4/fA9RtCz MqUzTWD81lGr/L6Qa9eVPHYrsjJ06Ce7YKyLSTPbykIq3BfY7kyHju8sfdG5wovXIMkF XSf6nzbwlRZhGUWIifzdNzxYpyopCh5WAmDX9bFXj7GggSWjQVpRh1q7EQxJa7igQ7N3 8+Kw== X-Gm-Message-State: AOAM533k9KihEmT/CAIs09O1plfoQHgFMZsG+J7TCZuTxJ3D2TCYymFM 9uiEXQvEi4P5WTcYL5iuZSk= X-Google-Smtp-Source: ABdhPJzeQmjKwbJOIh35vt/GlskZevTMXjOPZ7992olPxBR9T3iaGQHZyZ4BKIpzU8Nu/iE9IlED2A== X-Received: by 2002:a17:902:bc48:b029:f2:7db5:4d78 with SMTP id t8-20020a170902bc48b02900f27db54d78mr2379827plz.55.1621312978940; Mon, 17 May 2021 21:42:58 -0700 (PDT) Received: from localhost.localdomain ([203.126.139.7]) by smtp.gmail.com with ESMTPSA id t15sm357538pjh.0.2021.05.17.21.42.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 May 2021 21:42:58 -0700 (PDT) From: Desmond Cheong Zhi Xi To: gregkh@linuxfoundation.org, marcocesati@gmail.com, dan.carpenter@oracle.com, fabioaiuto83@gmail.com, fmdefrancesco@gmail.com, eantoranz@gmail.com, hdegoede@redhat.com, Larry.Finger@lwfinger.net Cc: Desmond Cheong Zhi Xi , skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: [PATCH v2 0/7] Staging: rtl8723bs: fix warnings in HalBtc8723b1Ant.c Date: Tue, 18 May 2021 00:41:12 -0400 Message-Id: <20210518044119.2960494-1-desmondcheongzx@gmail.com> X-Mailer: git-send-email 2.25.1 X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patchset fixes 134 checkpatch.pl warnings in the file drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c Although checkpatch.pl reports a large number of checks, these are for issues that were present in the original code. In fact, in the process of fixing warnings, the total number of checks decreased from 548 to 545. All patches are syntax fixes and no logic is changed. As there are a lot of different warnings, to make things easier to review, each patch addresses a different set of warnings in the following order: - braces {} are not necessary for any arm of this statement - please, no space before tabs - suspect code indent for conditional statements - Statements should start on a tabstop (this type of warning is solved alongside the previous warning type in the same patch because the fix for one warning addresses the other) - Comparisons should place the constant on the right side of the test - Missing a blank line after declarations - Avoid unnecessary line continuations - Block comments use * on subsequent lines Change in v2: - Patch 7: Remove dead code inside block comment instead of changing the comment formatting, as suggested by Dan Carpenter Desmond Cheong Zhi Xi (7): Staging: rtl8723bs: remove unnecessary braces in HalBtc8723b1Ant.c Staging: rtl8723bs: fix spaces in HalBtc8723b1Ant.c Staging: rtl8723bs: fix indentation in HalBtc8723b1Ant.c Staging: rtl8723bs: fix comparison formatting in HalBtc8723b1Ant.c Staging: rtl8723bs: add missing blank line in HalBtc8723b1Ant.c Staging: rtl8723bs: fix line continuations in HalBtc8723b1Ant.c Staging: rtl8723bs: remove dead code in HalBtc8723b1Ant.c .../staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 333 ++++++++---------- 1 file changed, 154 insertions(+), 179 deletions(-) -- 2.25.1