From: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>
To: gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
ross.schm.dev@gmail.com, straube.linux@gmail.com
Cc: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@bger.kernel.org
Subject: [PATCH 0/2] [RFC] staging: rtl8723bs: refactor to reduce indents
Date: Sat, 22 May 2021 14:47:17 +0530 [thread overview]
Message-ID: <20210522091719.64277-1-chouhan.shreyansh630@gmail.com> (raw)
This patch series tries to fix the following warnings by checkpatch.pl
in core/rtw_wlan_util.c:
WARNING: Too many leading tabs - consider code refactoring
#887: FILE: rtw_wlan_util.c:887:
+ if ((edca[j] >> 16) > (edca[i] >> 16))
WARNING: Too many leading tabs - consider code refactoring
#1529: FILE: rtw_wlan_util.c:1529:
+ if (pIE->data[5] & RT_HT_CAP_USE_92SE)
WARNING: Too many leading tabs - consider code refactoring
#1537: FILE: rtw_wlan_util.c:1537:
+ if (pIE->data[6] & RT_HT_CAP_USE_JAGUAR_BCUT)
WARNING: Too many leading tabs - consider code refactoring
#1540: FILE: rtw_wlan_util.c:1540:
+ if (pIE->data[6] & RT_HT_CAP_USE_JAGUAR_CCUT)
I wanted to ask for comments on the names of these functions and if such
a patch series would be acceptable.
The first patch refactors the code by introducing two new functions
sort_wmm_ac_params and get_realtek_assoc_AP_vender.
The second patch removes unnecessary braces from the conditional
statements in check_assoc_AP function.
Shreyansh Chouhan (2):
staging: rtl8723bs: refactor to reduce indents
staging: rtl8723bs: remove unnecessary braces from conditionals
.../staging/rtl8723bs/core/rtw_wlan_util.c | 141 +++++++++---------
1 file changed, 72 insertions(+), 69 deletions(-)
--
2.31.1
next reply other threads:[~2021-05-22 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 9:17 Shreyansh Chouhan [this message]
2021-05-22 9:17 ` [PATCH 1/2] [RFC] staging: rtl8723bs: refactor to reduce indents Shreyansh Chouhan
2021-05-24 9:05 ` Dan Carpenter
2021-05-24 16:06 ` Shreyansh Chouhan
2021-05-22 9:17 ` [PATCH 2/2] [RFC] staging: rtl8723bs: remove unnecessary braces from conditionals Shreyansh Chouhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210522091719.64277-1-chouhan.shreyansh630@gmail.com \
--to=chouhan.shreyansh630@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@bger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ross.schm.dev@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox