From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98AF8168 for ; Thu, 24 Jun 2021 12:00:35 +0000 (UTC) Received: by mail-pf1-f169.google.com with SMTP id g21so3268438pfc.11 for ; Thu, 24 Jun 2021 05:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AIOGsHWLRny/cPcLESp662rsTaSLQc4NuErEHrE2mZs=; b=h2+QfjQyzHfvVgntvTZbXhaDnuTPh8GWLZuhDjHTvWWIdTAg966MGSSwhKbz+93L+X sdqbC27IL1Qa3v0uC/AM1A0cXhp2SVlgLMoCX4+9SxLXil3KgFr1qsRSpkGNUJN5LRU3 Qa/PgGfanLESeHeCjKGdY7OVSlu+MlkbTHnzW4+/EdSNwNzbueEa3xnsOGbLEWVj7REo /KIgr2RnRKrmDQtdoXlW/3FfCgANIATswe8YduAL0Nbwmz6jJdQjIPT1HXLSRskONU05 6EinNoy32Sq6xDfvp5CX4TRToTYNUHAC++qkc9TkfD5CDrcD8pVgKZjTCZmGDAqYOZQZ A5AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AIOGsHWLRny/cPcLESp662rsTaSLQc4NuErEHrE2mZs=; b=nFOsjWPN3hiktctcLzU8PF73a6W6E83P1W1lgHebYgsMkRvSmHcXQ9jeuoobi0+bdZ Aw/A8nZKf0YDwP8wcfJvcyVkiNstD/cTUp55TlW/4LVplDyXd1Jl3luH5zuvKgRYbe9L BlaxDquilWvNgFwGVcFQgzXfE7jQCoCKayoxn0xLTO1xw+25PlVNZKPKLIQsCvhtkkjo yjAJXcbuAbnWpGp8RhowQOM27yV1bAsg6EddXVIrZRXMZni1qyp/jECgd0DryOaepeag 0hUWWLJw0RZC1ip1OSjNgWZfHpYu9MmqgT1xYyDHibxp2Jo5E0U5Ez0nqK7Dwm7gdKj5 PXew== X-Gm-Message-State: AOAM530aeOYoFMyC+SlRVBQrV5bqLAdCD4YhkmQlPY2FpBhOrkdoW+s2 t4frMWrmcqYHY1bNgZkY8sw= X-Google-Smtp-Source: ABdhPJzSlI8z9jpaMu8p5kCr79fbC+i63j1HqC/lmrRGUzV952gJivnulyalhSb5ZotCr/ggS9z2Zg== X-Received: by 2002:a63:582:: with SMTP id 124mr4489536pgf.132.1624536035097; Thu, 24 Jun 2021 05:00:35 -0700 (PDT) Received: from localhost ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id o9sm2965844pfh.217.2021.06.24.05.00.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 05:00:34 -0700 (PDT) From: Coiby Xu X-Google-Original-From: Coiby Xu Date: Thu, 24 Jun 2021 19:55:36 +0800 To: Dan Carpenter Cc: linux-staging@lists.linux.dev, netdev@vger.kernel.org, Benjamin Poirier , Shung-Hsi Yu , Manish Chopra , "supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER" , Greg Kroah-Hartman , Nathan Chancellor , Nick Desaulniers , open list , "open list:CLANG/LLVM BUILD SUPPORT" Subject: Re: [RFC 17/19] staging: qlge: fix weird line wrapping Message-ID: <20210624115536.5y4oqzrbms63rjcy@Rk> References: <20210621134902.83587-1-coiby.xu@gmail.com> <20210621134902.83587-18-coiby.xu@gmail.com> <20210622084611.GM1861@kadam> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210622084611.GM1861@kadam> On Tue, Jun 22, 2021 at 11:46:11AM +0300, Dan Carpenter wrote: >On Mon, Jun 21, 2021 at 09:49:00PM +0800, Coiby Xu wrote: >> @@ -524,8 +523,8 @@ static int qlge_set_routing_reg(struct qlge_adapter *qdev, u32 index, u32 mask, >> { >> value = RT_IDX_DST_DFLT_Q | /* dest */ >> RT_IDX_TYPE_NICQ | /* type */ >> - (RT_IDX_IP_CSUM_ERR_SLOT << >> - RT_IDX_IDX_SHIFT); /* index */ >> + (RT_IDX_IP_CSUM_ERR_SLOT >> + << RT_IDX_IDX_SHIFT); /* index */ > >The original is not great but the new indenting is definitely worse. >It might look nicer with the comments moved in the front? Why does >RT_IDX_IDX_SHIFT have two IDX strings? I'm not sure about it. Two IDX strings seems to be a typo. > > /* value = dest | type | index; */ > value = RT_IDX_DST_DFLT_Q | > RT_IDX_TYPE_NICQ | > (RT_IDX_IP_CSUM_ERR_SLOT << RT_IDX_IDX_SHIFT); > This looks better! Thanks! > >> break; >> } >> case RT_IDX_TU_CSUM_ERR: /* Pass up TCP/UDP CSUM error frames. */ >> @@ -554,7 +553,8 @@ static int qlge_set_routing_reg(struct qlge_adapter *qdev, u32 index, u32 mask, >> { >> value = RT_IDX_DST_DFLT_Q | /* dest */ >> RT_IDX_TYPE_NICQ | /* type */ >> - (RT_IDX_MCAST_MATCH_SLOT << RT_IDX_IDX_SHIFT);/* index */ >> + (RT_IDX_MCAST_MATCH_SLOT >> + << RT_IDX_IDX_SHIFT); /* index */ > >Original is better. I'll also move the comments in the front. > >> break; >> } >> case RT_IDX_RSS_MATCH: /* Pass up matched RSS frames. */ >> @@ -648,15 +648,15 @@ static int qlge_read_flash_word(struct qlge_adapter *qdev, int offset, __le32 *d >> { >> int status = 0; >> /* wait for reg to come ready */ >> - status = qlge_wait_reg_rdy(qdev, >> - FLASH_ADDR, FLASH_ADDR_RDY, FLASH_ADDR_ERR); >> + status = qlge_wait_reg_rdy(qdev, FLASH_ADDR, FLASH_ADDR_RDY, >> + FLASH_ADDR_ERR); >> if (status) >> goto exit; >> /* set up for reg read */ >> qlge_write32(qdev, FLASH_ADDR, FLASH_ADDR_R | offset); >> /* wait for reg to come ready */ >> - status = qlge_wait_reg_rdy(qdev, >> - FLASH_ADDR, FLASH_ADDR_RDY, FLASH_ADDR_ERR); >> + status = qlge_wait_reg_rdy(qdev, FLASH_ADDR, FLASH_ADDR_RDY, >> + FLASH_ADDR_ERR); >> if (status) >> goto exit; >> /* This data is stored on flash as an array of >> @@ -792,8 +792,8 @@ static int qlge_write_xgmac_reg(struct qlge_adapter *qdev, u32 reg, u32 data) >> { >> int status; >> /* wait for reg to come ready */ >> - status = qlge_wait_reg_rdy(qdev, >> - XGMAC_ADDR, XGMAC_ADDR_RDY, XGMAC_ADDR_XME); >> + status = qlge_wait_reg_rdy(qdev, XGMAC_ADDR, XGMAC_ADDR_RDY, >> + XGMAC_ADDR_XME); >> if (status) >> return status; >> /* write the data to the data reg */ >> @@ -811,15 +811,15 @@ int qlge_read_xgmac_reg(struct qlge_adapter *qdev, u32 reg, u32 *data) >> { >> int status = 0; >> /* wait for reg to come ready */ >> - status = qlge_wait_reg_rdy(qdev, >> - XGMAC_ADDR, XGMAC_ADDR_RDY, XGMAC_ADDR_XME); >> + status = qlge_wait_reg_rdy(qdev, XGMAC_ADDR, XGMAC_ADDR_RDY, >> + XGMAC_ADDR_XME); > >Need a blank line after the declaration block. Sure, I will fix it in next version. > >> if (status) >> goto exit; >> /* set up for reg read */ >> qlge_write32(qdev, XGMAC_ADDR, reg | XGMAC_ADDR_R); >> /* wait for reg to come ready */ >> - status = qlge_wait_reg_rdy(qdev, >> - XGMAC_ADDR, XGMAC_ADDR_RDY, XGMAC_ADDR_XME); >> + status = qlge_wait_reg_rdy(qdev, XGMAC_ADDR, XGMAC_ADDR_RDY, >> + XGMAC_ADDR_XME); >> if (status) >> goto exit; >> /* get the data */ > >regards, >dan carpenter -- Best regards, Coiby