From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 768B82FB0 for ; Wed, 21 Jul 2021 10:10:38 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id AFE3F6108B; Wed, 21 Jul 2021 10:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626862238; bh=xlNP5a4uduYvyMqVF4Oq/f5D4uaNQN51y0PLueC06Os=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EBo9p2yYYcIhOINxDz4pJjeRD+z/tvNLVzQoC71kmOBTNtDVF1poAeRj3Sq412JxZ v5JSyAmYQbmMUNybwD0NkPlWVAJZksPNP3tmLoY1JhdcrM09uQGXcRS4/WerD7E7Ir 6NfeqeFPiKiQa6pFzZBdGAZDw/KPsrbkRCAxUhQmEAov0iJzWY5PRfZ4w289WDGo7Y sOPiPKHoH7ky9ICLk+BFTRnAGx7KSwnzmzncT57T3S7lZB0uaWYYCyg0/XakErPiW8 HIgqzNZ23c6AKgTIaKiXK8ZqauPAOOv9m3ChJFm7JY4UGUBKbuJ3krSU0UfHy+Qh4w VNHnn4IT99Rjg== Date: Wed, 21 Jul 2021 12:10:31 +0200 From: Mauro Carvalho Chehab To: Greg Kroah-Hartman , Mark Brown Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Arnd Bergmann , Lee Jones , Liam Girdwood , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v14 5/9] staging: hi6421-spmi-pmic: cleanup drvdata Message-ID: <20210721121031.04bcadcc@coco.lan> In-Reply-To: References: <723edefbb2e9ce0b70d9c7bce95f288e3ea1f5b1.1626515862.git.mchehab+huawei@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Em Wed, 21 Jul 2021 11:25:47 +0200 Greg Kroah-Hartman escreveu: > On Sat, Jul 17, 2021 at 11:58:16AM +0200, Mauro Carvalho Chehab wrote: > > There are lots of fields at struct hi6421_spmi_pmic that aren't > > used. In a matter of fact, only regmap is needed. > > > > So, drop the struct as a hole, and set just the regmap as > > the drvdata. > > > > While here, add a missing dot at the Huawei's copyrights. > > > > Acked-by: Mark Brown > > Signed-off-by: Mauro Carvalho Chehab > > --- > > drivers/misc/hi6421v600-irq.c | 9 ++++---- > > drivers/regulator/hi6421v600-regulator.c | 10 ++++----- > > drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 16 +++++-------- > > include/linux/mfd/hi6421-spmi-pmic.h | 25 --------------------- > > 4 files changed, 14 insertions(+), 46 deletions(-) > > delete mode 100644 include/linux/mfd/hi6421-spmi-pmic.h > > This patch fails to apply to my 5.14-rc2 tree, it gets a failure in the > regulator portion of the patch. Hi Greg, This one depends on a regression-fix patch merged via this branch: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next The patch is this one[1]: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/drivers/regulator/hi6421v600-regulator.c?id=5db5dd5be70eaf808d9fd90174b957fc5c2912cb Mark, Is this branch stable or do you rebase it? If the branch is stable, then perhaps Greg could merge from it before applying the remaining patches from this series. - [1] There's no need of backporting the fix to stable, as the driver won't work with upstream Kernels without patches 8 and 9 from this series containing the Open Firmware data needed to probe it. Thanks, Mauro