From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88EC272 for ; Wed, 28 Jul 2021 01:30:13 +0000 (UTC) Received: by mail-pl1-f173.google.com with SMTP id i10so751554pla.3 for ; Tue, 27 Jul 2021 18:30:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F/W78E3w8bd3psxYX0IIxref8Eo+wzHY8m4KRkXjPMs=; b=fSpVrx2KFTwbTxZxaxYBjKJ9a3HRRpiHfBG8wD07VjuWC7mdbYEQ/7GkiPoSY+/g36 +TtB+dCcoMKG1TPpgjH+W/O2nqputas/NPxb5d/iKCDtXteeWA5Muau5Hiw7k0rZrmBp XaotHXeRLZbN2gC+C3tJaqkKc+t5iWRCRbObY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F/W78E3w8bd3psxYX0IIxref8Eo+wzHY8m4KRkXjPMs=; b=oLzFQd1+I1WB/ecgQdhORs0p8sVhPzw7e7Kyr+W3EMBttlIzH1qaG+K+PderimMCma 8eScOaN/abVj5FjH+WZy+/Np8YvXuACBOF/gR3h2KQQNBQNbvIo92/whx5uU8pPDajUz mjKJNsOErZe3xcYiSxow1HPRkvqM/NcUX+mlyuiYEJwPrQk/GMloTZjTIn9AKNQzVAqr 1giI6kC6Eeft5zRbNQpj/djg2V6VCvwbldD3AW8UTtF4qcfaaspXqDk8vcoRoPrxG/ns x/fpkOBUNqjdN8BTvB48wpQ/9ugG2Nzc7F/i2Ef0OP8p+3xhaQnRdQdFGta8xYtbvBiu x4Sg== X-Gm-Message-State: AOAM531tAoyA/FZ/VS7siDoJXm/xOSpIhgLdpfCterfwvVTSMD+gv4YI D/OYzPi23V8AxfEQqV18Kjmjlw== X-Google-Smtp-Source: ABdhPJwJtaC/+3L1bVkg9P8zv+anpCg9BvvGSgBVtWnX3lLVWENuhM7S6jL/vTi/ew8TMCXVE//XxA== X-Received: by 2002:a17:90a:ca93:: with SMTP id y19mr7226022pjt.142.1627435813032; Tue, 27 Jul 2021 18:30:13 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id r13sm5628761pgi.78.2021.07.27.18.30.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jul 2021 18:30:12 -0700 (PDT) Date: Tue, 27 Jul 2021 18:30:11 -0700 From: Kees Cook To: Bart Van Assche Cc: linux-hardening@vger.kernel.org, "Gustavo A. R. Silva" , Keith Packard , Greg Kroah-Hartman , Andrew Morton , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-staging@lists.linux.dev, linux-block@vger.kernel.org, linux-kbuild@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH 33/64] lib: Introduce CONFIG_TEST_MEMCPY Message-ID: <202107271829.CE9BADDB@keescook> References: <20210727205855.411487-1-keescook@chromium.org> <20210727205855.411487-34-keescook@chromium.org> <9827144a-dacf-61dc-d554-6c69434708de@acm.org> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9827144a-dacf-61dc-d554-6c69434708de@acm.org> On Tue, Jul 27, 2021 at 04:31:03PM -0700, Bart Van Assche wrote: > On 7/27/21 1:58 PM, Kees Cook wrote: > > +static int __init test_memcpy_init(void) > > +{ > > + int err = 0; > > + > > + err |= test_memcpy(); > > + err |= test_memmove(); > > + err |= test_memset(); > > + > > + if (err) { > > + pr_warn("FAIL!\n"); > > + err = -EINVAL; > > + } else { > > + pr_info("all tests passed\n"); > > + } > > + > > + return err; > > +} > > + > > +static void __exit test_memcpy_exit(void) > > +{ } > > + > > +module_init(test_memcpy_init); > > +module_exit(test_memcpy_exit); > > +MODULE_LICENSE("GPL"); > > Has it been considered to implement this test using the Kunit framework? Good point! I will see if that works here; it would make sense to make this KUnit from the start. -- Kees Cook