From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from viti.kaiser.cx (viti.kaiser.cx [85.214.81.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 206B170 for ; Thu, 5 Aug 2021 14:51:10 +0000 (UTC) Received: from dslb-188-096-137-143.188.096.pools.vodafone-ip.de ([188.96.137.143] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1mBei8-0003eR-4B; Thu, 05 Aug 2021 16:51:04 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH v2] staging: r8188eu: remove label at the end of a function Date: Thu, 5 Aug 2021 16:50:26 +0200 Message-Id: <20210805145026.14572-1-martin@kaiser.cx> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210805130750.7974-1-martin@kaiser.cx> References: <20210805130750.7974-1-martin@kaiser.cx> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Compilation fails for me drivers/staging/r8188eu/hal/rtl8188e_dm.c: In function ‘rtl8188e_HalDmWatchDog’: drivers/staging/r8188eu/hal/rtl8188e_dm.c:182:1: error: label at end of compound statement 182 | skip_dm: | ^~~~~~~ Remove the label at the end of the function. Replace the jump to this label with a return statement. Fixes: b398ff88aa36 ("staging: r8188eu: remove return from void functions") Signed-off-by: Martin Kaiser --- v2: - add Fixes tag drivers/staging/r8188eu/hal/rtl8188e_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_dm.c b/drivers/staging/r8188eu/hal/rtl8188e_dm.c index b5f42127a751..72b3130eddd2 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_dm.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_dm.c @@ -145,7 +145,7 @@ void rtl8188e_HalDmWatchDog(struct adapter *Adapter) hw_init_completed = Adapter->hw_init_completed; if (!hw_init_completed) - goto skip_dm; + return; fw_cur_in_ps = Adapter->pwrctrlpriv.bFwCurrentInPSMode; rtw_hal_get_hwreg(Adapter, HW_VAR_FWLPS_RF_ON, (u8 *)(&fw_ps_awake)); @@ -179,7 +179,7 @@ void rtl8188e_HalDmWatchDog(struct adapter *Adapter) ODM_CmnInfoUpdate(&hal_data->odmpriv, ODM_CMNINFO_LINK, bLinked); ODM_DMWatchdog(&hal_data->odmpriv); } -skip_dm: + /* Check GPIO to determine current RF on/off and Pbc status. */ /* Check Hardware Radio ON/OFF or not */ } -- 2.20.1