From: Martin Kaiser <martin@kaiser.cx>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Dan Carpenter <dan.carpenter@oracle.com>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH 4/5] staging: r8188eu: use proper way to build a module
Date: Wed, 11 Aug 2021 22:14:49 +0200 [thread overview]
Message-ID: <20210811201450.31366-4-martin@kaiser.cx> (raw)
In-Reply-To: <20210811201450.31366-1-martin@kaiser.cx>
It seems that for now, we can only build this driver as a module.
Use the same mechanism as other drivers (such as rtl8723bs or the
deprecated rtl8188eu) to enforce building as a module, i.e. depend on m
in Kconfig instead of setting CONFIG_R8188EU = m in the Makefile.
If we set CONFIG_R8188EU in the Makefile, this setting will not be visible
in .config.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/Kconfig | 1 +
drivers/staging/r8188eu/Makefile | 2 --
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/r8188eu/Kconfig b/drivers/staging/r8188eu/Kconfig
index 6323d63a4a1b..dc1719d3f2e4 100644
--- a/drivers/staging/r8188eu/Kconfig
+++ b/drivers/staging/r8188eu/Kconfig
@@ -2,6 +2,7 @@
config R8188EU
tristate "Realtek RTL8188EU Wireless LAN NIC driver"
depends on WLAN && USB && CFG80211
+ depends on m
select WIRELESS_EXT
select WEXT_PRIV
select LIB80211
diff --git a/drivers/staging/r8188eu/Makefile b/drivers/staging/r8188eu/Makefile
index 7f6658f931d1..cca7a58c5f29 100644
--- a/drivers/staging/r8188eu/Makefile
+++ b/drivers/staging/r8188eu/Makefile
@@ -4,8 +4,6 @@ EXTRA_CFLAGS += -O1
ccflags-y += -D__CHECK_ENDIAN__
-CONFIG_R8188EU = m
-
CONFIG_USB_HCI = y
CONFIG_BT_COEXIST = n
--
2.20.1
next prev parent reply other threads:[~2021-08-11 20:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 20:14 [PATCH 1/5] staging: r8188eu: remove unused efuse hal components Martin Kaiser
2021-08-11 20:14 ` [PATCH 2/5] staging: r8188eu: remove unused function parameters Martin Kaiser
2021-08-11 23:50 ` Phillip Potter
2021-08-11 20:14 ` [PATCH 3/5] staging: r8188eu: (trivial) remove a duplicate debug print Martin Kaiser
2021-08-11 23:53 ` Phillip Potter
2021-08-12 6:17 ` Dan Carpenter
2021-08-13 10:05 ` Martin Kaiser
2021-08-13 12:42 ` Fabio M. De Francesco
2021-08-14 16:54 ` Phillip Potter
2021-08-14 18:18 ` Fabio M. De Francesco
2021-08-11 20:14 ` Martin Kaiser [this message]
2021-08-11 23:53 ` [PATCH 4/5] staging: r8188eu: use proper way to build a module Phillip Potter
2021-08-11 20:14 ` [PATCH 5/5] staging: r8188eu: remove CONFIG_USB_HCI from Makefile Martin Kaiser
2021-08-11 23:54 ` Phillip Potter
2021-08-11 23:49 ` [PATCH 1/5] staging: r8188eu: remove unused efuse hal components Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210811201450.31366-4-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox