Re: [PATCH 3/3] staging: r8188eu: Reorganize error handling in rtw_drv_init()

Fabio M. De Francesco
2021-08-13T01:51:57Z

On Friday, August 13, 2021 1:14:01 AM CEST Nathan Chancellor wrote:
> On 8/12/2021 4:11 PM, Fabio M. De Francesco wrote:
> > On Thursday, August 12, 2021 10:40:27 PM CEST Nathan Chancellor wrote:
> > [...]
> > Therefore, apart that minor misuse of the "global" class in your commit
> > message, it's a nice work and so...
>
> I am happy to redo the commit message if you and others so desire.
>
> > Acked-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
>
> Thank you for the review and ack!
>
> Cheers,
> Nathan
>
Maybe that for that minor misuse of the definition of "global variable" it
isn't worth to redo three patches. If I were you, I'd wait for feedback from
Greg K-H and then I'd act accordingly.

But, at my first read of your patch, I didn't notice that when you return the
error from within the block starting at the "err:" label, "ret" is always set
as "-ENODEV".

So, why not simply "return -ENODEV;" and get rid of the "ret" variable?

Thanks,

Fabio