From: Kees Cook <keescook@chromium.org>
To: Aakash Hemadri <aakashhemadri123@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: fix invalid assignment warning
Date: Fri, 27 Aug 2021 22:58:30 -0700 [thread overview]
Message-ID: <202108272257.7396C4D146@keescook> (raw)
In-Reply-To: <20210828042949.2276341-1-aakashhemadri123@gmail.com>
On Sat, Aug 28, 2021 at 09:59:49AM +0530, Aakash Hemadri wrote:
> p80211_hdr->frame_control is u16, change to __le16
> to satisfy sparse warning:
>
> wlan-ng/prism2sta.c:253:43: warning: invalid assignment: |=
> wlan-ng/prism2sta.c:253:43: left side has type unsigned short
> wlan-ng/prism2sta.c:253:43: right side has type restricted __le16
>
> Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
Whoops; thanks for catching that.
Fixes: 6277fbfdd29c ("staging: wlan-ng: Remove pointless a3/a4 union")
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> drivers/staging/wlan-ng/p80211hdr.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/p80211hdr.h b/drivers/staging/wlan-ng/p80211hdr.h
> index dd1fb99bf340..5871a55e4a61 100644
> --- a/drivers/staging/wlan-ng/p80211hdr.h
> +++ b/drivers/staging/wlan-ng/p80211hdr.h
> @@ -149,7 +149,7 @@
> /* Generic 802.11 Header types */
>
> struct p80211_hdr {
> - u16 frame_control;
> + __le16 frame_control;
> u16 duration_id;
> u8 address1[ETH_ALEN];
> u8 address2[ETH_ALEN];
>
> base-commit: f6bc526accf861728d36b12fbc25ac94cd057fc9
> --
> 2.32.0
>
--
Kees Cook
prev parent reply other threads:[~2021-08-28 5:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 4:29 [PATCH] staging: wlan-ng: fix invalid assignment warning Aakash Hemadri
2021-08-28 5:58 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108272257.7396C4D146@keescook \
--to=keescook@chromium.org \
--cc=aakashhemadri123@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox