public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
To: Kari Argillander <kari.argillander@gmail.com>
Cc: gregkh@linuxfoundation.org, hello@bryanbrattlof.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: fix docs typos and references to previous struct names
Date: Sat, 28 Aug 2021 22:43:38 +1200	[thread overview]
Message-ID: <20210828104338.GA8113@localhost.localdomain> (raw)
In-Reply-To: <20210828102302.d7nhe2bkw6h5quqa@kari-VirtualBox>

On Sat, Aug 28, 2021 at 01:23:02PM +0300, Kari Argillander wrote:
> 
> Re: [PATCH] staging: pi433: fix ...
> 
> This is version 2. Subject needs to be [PATCH v2]. If you generate using
> git format-patch add "-v 2" in there.
> 
> On Sat, Aug 28, 2021 at 10:12:42PM +1200, Paulo Miguel Almeida wrote:
> > In the comments there where some grammar mistakes and references to
> > struct names that have gotten renamed over time but not updated
> > in the comments.
> > 
> > Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
> > ---
> 
> You should have log here what did you change from previous version as
> this is v2. You can also add who ask this change That should be like
> this:
> 
> ---
> Put your version log here.
> ---
> 

I see. Will do, thanks Kari :-)


  reply	other threads:[~2021-08-28 10:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-28 10:12 [PATCH] staging: pi433: fix docs typos and references to previous struct names Paulo Miguel Almeida
2021-08-28 10:23 ` Kari Argillander
2021-08-28 10:43   ` Paulo Miguel Almeida [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-08-28  0:08 Paulo Miguel Almeida
2021-08-28  6:12 ` Greg KH
2021-08-28  9:27   ` Paulo Miguel Almeida
2021-08-28  9:44     ` Greg KH
2021-08-28 10:00       ` Paulo Miguel Almeida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210828104338.GA8113@localhost.localdomain \
    --to=paulo.miguel.almeida.rodenas@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hello@bryanbrattlof.com \
    --cc=kari.argillander@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox