public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Krish Jain <krishjain02939@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev
Subject: [PATCH] Use BIT macro instead of (1 << HSDMA_GLO_BT_SHIFT)
Date: Thu, 2 Sep 2021 13:52:15 +0200	[thread overview]
Message-ID: <20210902115215.GA582112@panther> (raw)

This patch replaces (1 << HSDMA_GLO_BT_SHIFT) with the BIT(x) macro, as suggested by checkpatch.pl, for the file drivers/staging/mt7621-dma/hsdma-mt7621.c .

Signed-off-by: Krish Jain <krishjain02939@gmail.com>

---
 drivers/staging/mt7621-dma/hsdma-mt7621.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c
index 89b72a802800..a99cec876110 100644
--- a/drivers/staging/mt7621-dma/hsdma-mt7621.c
+++ b/drivers/staging/mt7621-dma/hsdma-mt7621.c
@@ -72,7 +72,7 @@
 #define HSDMA_GLO_TX_DMA		BIT(0)
 
 #define HSDMA_BT_SIZE_16BYTES		(0 << HSDMA_GLO_BT_SHIFT)
-#define HSDMA_BT_SIZE_32BYTES		(1 << HSDMA_GLO_BT_SHIFT)
+#define HSDMA_BT_SIZE_32BYTES		BIT(HSDMA_GLO_BT_SHIFT)
 #define HSDMA_BT_SIZE_64BYTES		(2 << HSDMA_GLO_BT_SHIFT)
 #define HSDMA_BT_SIZE_128BYTES		(3 << HSDMA_GLO_BT_SHIFT)
 
@@ -164,8 +164,7 @@ struct mtk_hsdam_engine {
 
 static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(struct mtk_hsdma_chan *chan)
 {
-	return container_of(chan->vchan.chan.device, struct mtk_hsdam_engine,
-			ddev);
+	return container_of(chan->vchan.chan.device, struct mtk_hsdam_engine, ddev);
 }
 
 static inline struct mtk_hsdma_chan *to_mtk_hsdma_chan(struct dma_chan *c)
-- 
2.25.1


             reply	other threads:[~2021-09-01 22:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 11:52 Krish Jain [this message]
2021-09-02  5:30 ` [PATCH] Use BIT macro instead of (1 << HSDMA_GLO_BT_SHIFT) Greg KH
2021-09-02  5:46   ` Krish Jain
2021-09-02  5:46     ` Krish Jain
2021-09-02  5:57       ` Greg KH
2021-09-03  8:10 ` Dan Carpenter
2021-09-03 15:52   ` Krish Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210902115215.GA582112@panther \
    --to=krishjain02939@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox