From: Dan Carpenter <dan.carpenter@oracle.com>
To: Alakesh Haloi <alakesh.haloi@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pavel Skripkin <paskripkin@gmail.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: staging: media: atomisp: fix return value
Date: Mon, 6 Sep 2021 10:32:19 +0300 [thread overview]
Message-ID: <20210906073219.GF1957@kadam> (raw)
In-Reply-To: <20210903200658.GA552296@ip-172-31-53-182.us-west-2.compute.internal>
On Fri, Sep 03, 2021 at 08:06:58PM +0000, Alakesh Haloi wrote:
> This fixes following error seen during module build
> error: control reaches end of non-void function [-Werror=return-type]
>
> Signed-off-by: Alakesh Haloi <alakesh.haloi@gmail.com>
> ---
> .../media/atomisp/pci/hive_isp_css_common/host/input_system.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> index 8e085dda0c18..5d088d6fb01f 100644
> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> @@ -1646,6 +1646,7 @@ static input_system_err_t input_system_configure_channel_sensor(
> default:
> return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
> }
> + return status;
You're working against a very old tree. This was fixed over a month
ago.
> }
regards,
dan carpenter
prev parent reply other threads:[~2021-09-06 7:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 20:06 [PATCH] media: staging: media: atomisp: fix return value Alakesh Haloi
2021-09-06 7:32 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906073219.GF1957@kadam \
--to=dan.carpenter@oracle.com \
--cc=alakesh.haloi@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=paskripkin@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox