From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D02472 for ; Sat, 25 Sep 2021 02:42:06 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 5254B60F6D; Sat, 25 Sep 2021 02:42:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632537725; bh=3qKrafgB+R9aRyaGwO41XzuxrHwCkhqpSPu2zki+01Q=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=nq/E5Tl8hN26pAjLMZx9l6bt3QGZdvGLZSB3OPXISzKglBhK0/b/vcUcseNhI6L/U t+hdZfH4Pps8t0EA+Litu66sWufsr5aR4u/Oa13MZAbEtf8U/nfukgezUI3MBtnkjm g1JjOvrQkX3SyVrRFsrTej4spU+wYVdRJl5BRoQXx2hKMNWEuT3POFGkB/vbVvMuwM fj4NS20JrdggcqqKe1tF8wrGG3JdDTBqOehwDtevHa/wtUU7Kl3k4Jh/FsNbTnBAvt CiumBeTCgRCF/J40Ur04jLsAvPxIsbFicf7ORh5qVwxBr2H/LimkLTwP6SMTV0gkTL fdqA4wLTjksDQ== Date: Fri, 24 Sep 2021 21:42:04 -0500 From: Bjorn Helgaas To: Sergio Paracuellos Cc: tsbogend@alpha.franken.de, robh@kernel.org, arnd@arndb.de, catalin.marinas@arm.com, Liviu.Dudau@arm.com, bhelgaas@google.com, matthias.bgg@gmail.com, gregkh@linuxfoundation.org, linux-mips@vger.kernel.org, linux-pci@vger.kernel.org, linux-staging@lists.linux.dev, neil@brown.name, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] PCI: allow architecture specific implementation of pci_remap_iospace() Message-ID: <20210925024204.GA459123@bhelgaas> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210924211139.3477-5-sergio.paracuellos@gmail.com> s/PCI: allow architecture specific implementation of/ PCI: Allow architecture-specific pci_remap_iospace()/ (in subject) On Fri, Sep 24, 2021 at 11:11:37PM +0200, Sergio Paracuellos wrote: > pci_remap_iospace() was originally meant as an architecture specific helper, > but it moved into generic code after all architectures had the same requirements. > MIPS has different requirements so it should not be shared. The way for doing > this will be using a macro 'pci_remap_iospace' defined for those architectures > that need a special treatement. Hence, put core api function inside preprocesor > conditional code for 'pci_remap_iospace' definition. Rewrap above to fit in 75 columns so "git log" output doesn't wrap. Add blank line between paragraphs. s/treatement/treatment/ s/api/API/ > Signed-off-by: Sergio Paracuellos With above fixed, Acked-by: Bjorn Helgaas > --- > drivers/pci/pci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index ce2ab62b64cf..0ec57bb01a88 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -4123,6 +4123,7 @@ unsigned long __weak pci_address_to_pio(phys_addr_t address) > * architectures that have memory mapped IO functions defined (and the > * PCI_IOBASE value defined) should call this function. > */ > +#ifndef pci_remap_iospace > int pci_remap_iospace(const struct resource *res, phys_addr_t phys_addr) > { > #if defined(PCI_IOBASE) && defined(CONFIG_MMU) > @@ -4146,6 +4147,7 @@ int pci_remap_iospace(const struct resource *res, phys_addr_t phys_addr) > #endif > } > EXPORT_SYMBOL(pci_remap_iospace); > +#endif > > /** > * pci_unmap_iospace - Unmap the memory mapped I/O space > -- > 2.25.1 >