From: Michael Estner <michaelestner@web.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: michaelestner@web.de, Lee Jones <lee.jones@linaro.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH] avoid crashing the kernel
Date: Sat, 25 Sep 2021 22:04:30 +0200 [thread overview]
Message-ID: <20210925200433.8329-1-michaelestner@web.de> (raw)
To avoid chrashing the kernel I use WARN_ON instead.
Signed-off-by: Michael Estner <michaelestner@web.de>
---
drivers/staging/most/i2c/i2c.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/i2c/i2c.c b/drivers/staging/most/i2c/i2c.c
index 7042f10887bb..e1edd892f9fd 100644
--- a/drivers/staging/most/i2c/i2c.c
+++ b/drivers/staging/most/i2c/i2c.c
@@ -68,7 +68,7 @@ static int configure_channel(struct most_interface *most_iface,
struct hdm_i2c *dev = to_hdm(most_iface);
unsigned int delay, pr;
- BUG_ON(ch_idx < 0 || ch_idx >= NUM_CHANNELS);
+ WARN_ON(ch_idx < 0 || ch_idx >= NUM_CHANNELS);
if (channel_config->data_type != MOST_CH_CONTROL) {
pr_err("bad data type for channel %d\n", ch_idx);
@@ -122,7 +122,7 @@ static int enqueue(struct most_interface *most_iface,
struct hdm_i2c *dev = to_hdm(most_iface);
int ret;
- BUG_ON(ch_idx < 0 || ch_idx >= NUM_CHANNELS);
+ WARN_ON(ch_idx < 0 || ch_idx >= NUM_CHANNELS);
if (ch_idx == CH_RX) {
/* RX */
@@ -167,7 +167,7 @@ static int poison_channel(struct most_interface *most_iface,
struct hdm_i2c *dev = to_hdm(most_iface);
struct mbo *mbo;
- BUG_ON(ch_idx < 0 || ch_idx >= NUM_CHANNELS);
+ WARN_ON(ch_idx < 0 || ch_idx >= NUM_CHANNELS);
if (ch_idx == CH_RX) {
if (!polling_rate)
--
2.25.1
next reply other threads:[~2021-09-25 20:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 20:04 Michael Estner [this message]
2021-09-26 6:51 ` [PATCH] avoid crashing the kernel Greg Kroah-Hartman
2021-09-26 8:38 ` Fabio M. De Francesco
2021-09-27 13:15 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210925200433.8329-1-michaelestner@web.de \
--to=michaelestner@web.de \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox