From: Dan Carpenter <dan.carpenter@oracle.com>
To: Michael Straube <straube.linux@gmail.com>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove rtl8188e_silentreset_for_specific_platform()
Date: Thu, 30 Sep 2021 15:39:37 +0300 [thread overview]
Message-ID: <20210930123937.GO2048@kadam> (raw)
In-Reply-To: <20210930085542.10222-1-straube.linux@gmail.com>
On Thu, Sep 30, 2021 at 10:55:42AM +0200, Michael Straube wrote:
> diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> index dd47098ed1e5..852f8e0bbf64 100644
> --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> @@ -4005,7 +4005,6 @@ static int rtw_dbg_port(struct net_device *dev,
> case 0x0f:
> if (extra_arg == 0) {
> DBG_88E("###### silent reset test.......#####\n");
> - rtl8188e_silentreset_for_specific_platform(padapter);
> }
This introduces a new checkpatch warning about unnessary curly braces.
Just delete the whole if statement.
regards,
dan carpenter
prev parent reply other threads:[~2021-09-30 12:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 8:55 [PATCH] staging: r8188eu: remove rtl8188e_silentreset_for_specific_platform() Michael Straube
2021-09-30 12:39 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210930123937.GO2048@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).