From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAF542F80 for ; Thu, 30 Sep 2021 21:49:33 +0000 (UTC) Received: by mail-ed1-f47.google.com with SMTP id dj4so28375048edb.5 for ; Thu, 30 Sep 2021 14:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FEOblmC0YUCEiWaIMk7PSN1i7kz3y2CTmP64nyEY6xY=; b=UmuryMZoRAKJ59bKvenZZV8El+IqNmrMKDsWe8MMB9yQVbNNgL88EtSJdjAIejm9oO kbZLkx0Vl9iz2zX2HfwHdt7Aym/qI3bkHAl47BI3na90LyXPYLgSKiCnWfk32Dto8hwn tlWDXHKG+Q2cc/I2KATh47GJBWsp/XxlHsR//1U2WPkmQ0OrUraQvsR/RH8M0mFGOvHH Dd++xJdH+UmFuEzyuaqiVgNQ8vKxRuMClZxlsfc7ZNNi2611CxKWKT5Xg/Rd3mPkGwwU 7C3D1VZSE51gM9ovSxmuji4D2bWPABK093UM93vUb+aEHV7BhdHPbI/mJ1oa90N/x7W7 pTMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FEOblmC0YUCEiWaIMk7PSN1i7kz3y2CTmP64nyEY6xY=; b=YCU5tbTfnbpUKly/8lsar4Irl6nk744eYl+VyoK9qRrP8fwE9vfQog4oioGQmXX4db xAHFL3vyVDYRXBPwNScqVPIEQ7ZsUvK4BfWqsVTuGki4/5wA4DKMynJoxg6PF6Pw1ROl 304jzDYaR9X6CaiMble9+LuFagfMLXCzazs6BKksw6RO7Sx2ePVIYKvVkqqXTkLBrp+K yU77l6IMjOmQnb/+BjIeip/F4l3ZsKudDanoi6Vh2uldgiw/zo67WBj8oavWydWqB0nH 8C/2gYS/SFnqrR4UcJA99FJvoJ+ZyYjIFVNTDMi6XQEWYcWI0NXGJJV7fXPPHIpY6EZM 9nRw== X-Gm-Message-State: AOAM533VGax34l67WUiGBDsrRLpZQdY2Ld6LQz7NWnrh2zGlUun0/+7m Vz+yMdGRkxX7DLdpJZeGWt4= X-Google-Smtp-Source: ABdhPJxEAUFLydNFx3P6tcdpsrekpJIwuSj1IYXnvIlRWEsyYFpSx2DC+9KuyUFAUad0bIuxOCEA5A== X-Received: by 2002:a17:906:3693:: with SMTP id a19mr1902627ejc.237.1633038571983; Thu, 30 Sep 2021 14:49:31 -0700 (PDT) Received: from tom-desktop (net-5-94-68-71.cust.vodafonedsl.it. [5.94.68.71]) by smtp.gmail.com with ESMTPSA id p15sm2149853edy.67.2021.09.30.14.49.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 14:49:31 -0700 (PDT) Date: Thu, 30 Sep 2021 23:49:29 +0200 From: Tommaso Merciai To: Greg Kroah-Hartman Cc: Forest Bond , Lucas Henneman , Yujia Qiao , Madhumitha Prabakaran , Marcos Antonio de Jesus Filho , Aldas =?utf-8?B?VGFyYcWha2V2acSNaXVz?= , "Gustavo A. R. Silva" , Deepak R Varma , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/3] staging: vt6655: fix camelcase in bShortSlotTime Message-ID: <20210930214929.GB45822@tom-desktop> References: <20210926162527.21462-1-tomm.merciai@gmail.com> <20210926162527.21462-2-tomm.merciai@gmail.com> <20210927213515.GA6953@tom-desktop> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Sep 28, 2021 at 06:43:00AM +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 27, 2021 at 11:35:15PM +0200, Tommaso Merciai wrote: > > On Mon, Sep 27, 2021 at 05:26:14PM +0200, Greg Kroah-Hartman wrote: > > > On Sun, Sep 26, 2021 at 06:25:18PM +0200, Tommaso Merciai wrote: > > > > Replace camel case variable bShortSlotTime with snake case > > > > variable b_short_slot_time. > > > > > > That is a very odd variable name. Why did you pick that one? > > > > > > What deos it mean? > > > > > > You do understand where the original naming format came from here, and > > > what it was trying to represent, right? If not, please go read up on > > > it: > > > https://en.wikipedia.org/wiki/Hungarian_notation > > > > > > That style is not used in Linux, and so, when converting from it, do not > > > attempt to keep the same style present here, that is kind of pointless, > > > don't you agree? > > > > You are definitely right. What do you think about "short_slot_time"? > > "time" implies that this will hold a value of time, right? > > What exactly does this variable do? That might help in naming it > better. Is a boolean variable, if true short slot time mode is enabled, false not right? A good solution could be: "short_slot_mode"? What do you think about? thanks, tommaso > > thanks, > > greg k-h