From: Dan Carpenter <dan.carpenter@oracle.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
ross.schm.dev@gmail.com, marcocesati@gmail.com,
insafonov@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
Subject: Re: [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement.
Date: Mon, 11 Oct 2021 15:30:25 +0300 [thread overview]
Message-ID: <20211011123024.GB8429@kadam> (raw)
In-Reply-To: <YWJ0vSrgsiKK7suE@user>
On Sun, Oct 10, 2021 at 10:36:05AM +0530, Saurav Girepunje wrote:
> Remove the unneeded and redundant check of variable on goto out.
> Simplify the return using multiple goto label to avoid
> unneeded check.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
No, sorry but the goto bunny hops, the pointless do-nothing gotos, and
the come from labels are all terrible.
regards,
dan carpenter
next prev parent reply other threads:[~2021-10-11 12:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 5:06 [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement Saurav Girepunje
2021-10-10 7:24 ` Fabio M. De Francesco
2021-10-11 18:10 ` Saurav Girepunje
2021-10-10 8:56 ` Pavel Skripkin
2021-10-10 12:59 ` Greg KH
2021-10-11 8:54 ` Fabio M. De Francesco
2021-10-11 12:33 ` Fabio M. De Francesco
2021-10-11 18:36 ` Saurav Girepunje
2021-10-11 17:32 ` Saurav Girepunje
2021-10-11 12:30 ` Dan Carpenter [this message]
2021-10-11 18:28 ` Saurav Girepunje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211011123024.GB8429@kadam \
--to=dan.carpenter@oracle.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=insafonov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
--cc=ross.schm.dev@gmail.com \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox