From: Dan Carpenter <dan.carpenter@oracle.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
ross.schm.dev@gmail.com, marcocesati@gmail.com,
insafonov@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: rtl8723bs: os_dep: simplify the return statement.
Date: Tue, 12 Oct 2021 09:34:46 +0300 [thread overview]
Message-ID: <20211012063446.GQ2083@kadam> (raw)
In-Reply-To: <05689c1a-546b-7d5d-0196-59f1a2caaba4@gmail.com>
On Mon, Oct 11, 2021 at 11:56:10PM +0530, Saurav Girepunje wrote:
>
> I didn't removed local variable assignment to NULL on this patch.
> However I agree this is another improvement possible on this function and can be done along with other changes.
> Please let me know you opinion whether I should send one patch or multiple patch in a single series.
Since it's on the same line then do it in one patch.
regards,
dan carpenter
prev parent reply other threads:[~2021-10-12 6:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 15:39 [PATCH] staging: rtl8723bs: os_dep: simplify the return statement Saurav Girepunje
2021-10-09 16:59 ` Fabio M. De Francesco
2021-10-09 18:17 ` Saurav Girepunje
2021-10-11 12:26 ` Dan Carpenter
2021-10-11 18:26 ` Saurav Girepunje
2021-10-12 6:34 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211012063446.GQ2083@kadam \
--to=dan.carpenter@oracle.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=insafonov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
--cc=ross.schm.dev@gmail.com \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox