From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Martin Kaiser <martin@kaiser.cx>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Subject: [PATCH v2 0/3] staging: r8188eu: use completions and clean rtw_cmd_thread()
Date: Sun, 17 Oct 2021 16:28:09 +0200 [thread overview]
Message-ID: <20211017142812.4656-1-fmdefrancesco@gmail.com> (raw)
This series replaces two semaphores with three completion variables
in rtw_cmd_thread(). Completions variables are better suited for the
purposes that are explained in detail in the commit messages of patches
1/3 and 2/3. Furthermore, patch 3/3 removes a redundant 'if' statement
from that same rtw_cmd_thread().
Tested with ASUSTek Computer, Inc. Realtek 8188EUS [USB-N10 Nano]
Many thanks to Dan Carpenter <dan.carpenter@oracle.com> who helped with
his review of the RFC Patch.
v1 => v2:
Patch 1/3: No changes;
Patch 2/3: Replace wait_for_completion_killable() with
wait_for_completion() because killing the kthread is
not allowed and so there is no need for killable
wait;
Patch 3/3: No changes.
Fabio M. De Francesco (3):
staging: r8188eu: Use completions for signaling start and end of
kthread
staging: r8188eu: Use completions for signaling enqueueing
staging: r8188eu: Remove redundant 'if' statement
drivers/staging/r8188eu/core/rtw_cmd.c | 20 +++++++-------------
drivers/staging/r8188eu/include/rtw_cmd.h | 5 +++--
drivers/staging/r8188eu/os_dep/os_intfs.c | 8 +++++---
3 files changed, 15 insertions(+), 18 deletions(-)
--
2.33.0
next reply other threads:[~2021-10-17 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 14:28 Fabio M. De Francesco [this message]
2021-10-17 14:28 ` [PATCH v2 1/3] staging: r8188eu: Use completions for signaling start / end kthread Fabio M. De Francesco
2021-10-17 14:28 ` [PATCH v2 2/3] staging: r8188eu: Use completions for signaling enqueueing Fabio M. De Francesco
2021-10-17 14:28 ` [PATCH 3/3] staging: r8188eu: Remove redundant 'if' statement Fabio M. De Francesco
2021-10-18 14:42 ` Greg Kroah-Hartman
2021-10-18 16:28 ` Fabio M. De Francesco
2021-10-19 5:51 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211017142812.4656-1-fmdefrancesco@gmail.com \
--to=fmdefrancesco@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox