From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3E8372 for ; Wed, 20 Oct 2021 20:26:56 +0000 (UTC) Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4AAB361354; Wed, 20 Oct 2021 20:26:54 +0000 (UTC) Date: Wed, 20 Oct 2021 21:31:12 +0100 From: Jonathan Cameron To: sesankm Cc: lars@metafoo.de, Michael.Hennerich@analog.com, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, sesankm <26676400+sesankm@users.noreply.github.com> Subject: Re: [PATCH] Staging: iio: adc: ad7280a: fixed coding style Message-ID: <20211020213112.6084a04c@jic23-huawei> In-Reply-To: <20211020061027.34148-1-26676400+sesankm@users.noreply.github.com> References: <20211020061027.34148-1-26676400+sesankm@users.noreply.github.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 20 Oct 2021 01:10:27 -0500 sesankm wrote: > fixed issue with coding style > > Signed-off-by: sesankm <26676400+sesankm@users.noreply.github.com> Ah. Our 'favourite' false positive. Take a look at what that macro is doing.. There is a series waiting for review that removes this code anyway... https://patchwork.kernel.org/project/linux-iio/list/?series=499867 > --- > drivers/staging/iio/adc/ad7280a.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c > index fef0055b8990..473f95118214 100644 > --- a/drivers/staging/iio/adc/ad7280a.c > +++ b/drivers/staging/iio/adc/ad7280a.c > @@ -829,14 +829,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private) > * The function argument is stringified and doesn't need a fix > */ > static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value, > - in_voltage-voltage_thresh_low_value, > + in_voltage - voltage_thresh_low_value, > 0644, > ad7280_read_channel_config, > ad7280_write_channel_config, > AD7280A_CELL_UNDERVOLTAGE); > > static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value, > - in_voltage-voltage_thresh_high_value, > + in_voltage - voltage_thresh_high_value, > 0644, > ad7280_read_channel_config, > ad7280_write_channel_config,