Re: [PATCH v3 0/3] PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver

Bjorn Helgaas
2021-10-21T18:11:47Z

On Thu, Oct 21, 2021 at 07:27:21PM +0200, Sergio Paracuellos wrote:
> On Thu, Oct 21, 2021 at 5:52 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> > Since this is a PCIe (not conventional PCI) controller, I vote for
> > renaming these from:
> >
> > PCI_MT7621
> > Documentation/devicetree/bindings/pci/mediatek,mt7621-pci.yaml
> > drivers/pci/controller/pci-mt7621.c
> >
> > to:
> >
> > PCIE_MT7621
> > Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> > drivers/pci/controller/pcie-mt7621.c
> >
> > We have a mix of these, with many of the early PCIe drivers being
> > named "pci", but I think that was my mistake and there's no reason to
> > continue it.
>
> I see.
>
> >
> > I can do this locally unless somebody objects.
>
> I have no problem at all. Only one question. Do you mean to change
> compatible string also, or only the name of the file? Let me know if I
> have to do anything.

I didn't change the compatible string, to avoid a DT incompatibility.
But I *did* change the Kconfig symbol to PCIE_MT7621, which could
require changes to out-of-tree .configs. I'm open to suggestions
either way for both things.