From: Dan Carpenter <dan.carpenter@oracle.com>
To: cgel.zte@gmail.com
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
gregkh@linuxfoundation.org, straube.linux@gmail.com,
fmdefrancesco@gmail.com, saurav.girepunje@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Changcheng Deng <deng.changcheng@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] staging: r8188eu: remove unneeded variable
Date: Fri, 5 Nov 2021 16:41:39 +0300 [thread overview]
Message-ID: <20211105134139.GC2001@kadam> (raw)
In-Reply-To: <20211102073226.7966-1-deng.changcheng@zte.com.cn>
On Tue, Nov 02, 2021 at 07:32:26AM +0000, cgel.zte@gmail.com wrote:
> @@ -1611,7 +1610,6 @@ unsigned int OnAtim(struct adapter *padapter, struct recv_frame *precv_frame)
>
> unsigned int on_action_spct(struct adapter *padapter, struct recv_frame *precv_frame)
> {
> - unsigned int ret = _FAIL;
> struct sta_info *psta = NULL;
> struct sta_priv *pstapriv = &padapter->stapriv;
> u8 *pframe = precv_frame->rx_data;
> @@ -1644,7 +1642,7 @@ unsigned int on_action_spct(struct adapter *padapter, struct recv_frame *precv_f
> }
>
> exit:
> - return ret;
> + return _FAIL;
> }
Heh... Let's make it return success on the success path. The other
implementation of this in rtl8723bs/ is wrong too.
No one ever checks, but it's called as a function pointer so we can't
make it void without changing a bunch of other code.
regards,
dan carpenter
next prev parent reply other threads:[~2021-11-05 13:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 7:32 [PATCH] staging: r8188eu: remove unneeded variable cgel.zte
2021-11-02 8:23 ` Pavel Skripkin
2021-11-05 13:41 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-09 11:53 cgel.zte
2021-11-09 12:09 ` Pavel Skripkin
2021-11-09 12:18 ` Dan Carpenter
2021-11-09 12:23 ` Pavel Skripkin
2021-11-10 8:12 ` Greg KH
2021-11-10 12:22 cgel.zte
2021-11-13 11:14 ` Greg KH
2021-11-12 13:18 cgel.zte
2021-11-12 16:31 ` Pavel Skripkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211105134139.GC2001@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=cgel.zte@gmail.com \
--cc=deng.changcheng@zte.com.cn \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=saurav.girepunje@gmail.com \
--cc=straube.linux@gmail.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).