From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C251D2C83 for ; Sat, 13 Nov 2021 09:16:37 +0000 (UTC) Received: by mail-ed1-f54.google.com with SMTP id g14so47668667edz.2 for ; Sat, 13 Nov 2021 01:16:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VfAYhPiwiwiyvWNQSEKAcTZOlquJvGTWd5nN82HonzY=; b=OVYHPNyZQS4RAhJEu5In/BmBPAq2bL60W3U0uzA9hwqeKqzykSGLHOVPGJrWwcFxWM Z4kyIsqfW48FsgvE9bc2vQWAncYeaDjiwM9C9eioXkCJcaNH6Sudf57eRUWPBr4oyfMV 0q1EazDu3swCwOhOmoozGcokrawI/agIvjPGi2gkqanFT6Bs08oi29xGMJdHojXfIh5R 9IZDbsux96ItRjB2ZbyV0NfYDB6dCknBqipHhubOQrIVLA1yiB0jDWTIRpE47DB8OlUs AEH3QK8rpPXChun5pOZWqfDMd5G1uSnLCKxLvE533za4hXmpNaSJHLWwuavpTrTXa2HL jLNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VfAYhPiwiwiyvWNQSEKAcTZOlquJvGTWd5nN82HonzY=; b=QCZct86un6ExiHqQAXReDSXmAw+W6lskNx7GYAek8eZlZ/woYH6yO6Df+j/HdnlkHJ bAnn9DDFXhS/gnc9zKAKRNyk37TYvCxhyFqNueDQi+XpqvClW24m+kM3QcNJo2ZOhDe2 hsKZfom7P4JSvVglmTIdiF923TzbN7yljTq/l9RKqBbomiKzFcJZqNpuOd0eyuOlvsgF ovH1vu3Zlrjr78mgXd6zVKF8YsyJPoEUzC5yo4pgY9s5FKrGZhCzTL0/Vq797JHwfYY3 B+lztKMNi0l/iDt2AAG/1Ow5UusFx5HmrQvAVXbxIsLPSXlHn4xwgr9nx59elfJF29y+ bvbw== X-Gm-Message-State: AOAM530/LmKaONol9WeKNuNyc9qd1vjbIa1RKM6KgNBFJAZiyFlORewn 0rheU4+UDgmkh+GBMOqM57A= X-Google-Smtp-Source: ABdhPJycnBdI30jFWyXBWYhK2yOWovViuMMV3gucOqpnXhqXIKcibg3kN66CzbX1mmxbxRmMetfP8w== X-Received: by 2002:a17:906:4fc8:: with SMTP id i8mr27483703ejw.342.1636794996097; Sat, 13 Nov 2021 01:16:36 -0800 (PST) Received: from tom-desktop (net-93-150-197-192.cust.vodafonedsl.it. [93.150.197.192]) by smtp.gmail.com with ESMTPSA id cw20sm3443714ejc.32.2021.11.13.01.16.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Nov 2021 01:16:35 -0800 (PST) Date: Sat, 13 Nov 2021 10:16:33 +0100 From: Tommaso Merciai To: Joe Perches Cc: Forest Bond , Greg Kroah-Hartman , Dan Carpenter , Lucas Henneman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: vt6655: fix camelcase byData in card.c Message-ID: <20211113091633.GA16307@tom-desktop> References: <20211106184822.24242-1-tomm.merciai@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Nov 06, 2021 at 12:06:30PM -0700, Joe Perches wrote: > On Sat, 2021-11-06 at 19:48 +0100, Tommaso Merciai wrote: > > Replace camelcase variable "byData" into linux kernel coding style > > equivalent variable "data" in card.c. > > "by" prefix in hungarian notation stands for byte or unsigned char > [] > > diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c > [] > > @@ -194,15 +194,15 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type) > > priv->abyBBVGA[0] = 0x20; > > priv->abyBBVGA[2] = 0x10; > > priv->abyBBVGA[3] = 0x10; > > - bb_read_embedded(priv, 0xE7, &byData); > > - if (byData == 0x1C) > > + bb_read_embedded(priv, 0xE7, &data); > > It might be nice to figure out what these register values are > and use #defines instead of hard coded values like 0xE7 Hi Joe, Thanks, I'm going to investigate these numbers. tommaso > > > + if (data == 0x1C) > > bb_write_embedded(priv, 0xE7, priv->abyBBVGA[0]); > > etc... >