From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vihas Mak <makvihas@gmail.com>
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
gregkh@linuxfoundation.org, straube.linux@gmail.com,
nathan@kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: use max() and min() macros
Date: Wed, 24 Nov 2021 16:14:14 +0300 [thread overview]
Message-ID: <20211124131414.GJ6514@kadam> (raw)
In-Reply-To: <20211123232551.210016-1-makvihas@gmail.com>
On Wed, Nov 24, 2021 at 04:55:51AM +0530, Vihas Mak wrote:
> +
> + min_MPDU_spacing = max(pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x1c,
> + pIE->data[i] & 0x1c);
Please run scripts/checkpatch.pl on your patches.
CHECK: Alignment should match open parenthesis
#41: FILE: drivers/staging/r8188eu/core/rtw_wlan_util.c:723:
+ min_MPDU_spacing = max(pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x1c,
+ pIE->data[i] & 0x1c);
regards,
dan carpenter
next prev parent reply other threads:[~2021-11-24 13:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 23:25 [PATCH] staging: r8188eu: use max() and min() macros Vihas Mak
2021-11-24 13:14 ` Dan Carpenter [this message]
2021-11-24 14:56 ` Vihas Mak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211124131414.GJ6514@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=makvihas@gmail.com \
--cc=nathan@kernel.org \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox