From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vihas Mak <makvihas@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Larry.Finger@lwfinger.net, Phillip Potter <phil@philpotter.co.uk>,
straube.linux@gmail.com, martin@kaiser.cx,
Pavel Skripkin <paskripkin@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove unnecessary NULL check
Date: Thu, 25 Nov 2021 10:09:14 +0300 [thread overview]
Message-ID: <20211125070914.GM6514@kadam> (raw)
In-Reply-To: <CAH1kMwRPLP998GjKx7bkL_LQE8hVNdCThwBJ7W8iNo1mPUyEZQ@mail.gmail.com>
On Thu, Nov 25, 2021 at 07:02:20AM +0530, Vihas Mak wrote:
> >> And are you sure this ever could be NULL?
> Yes.
>
> The function rtw_free_netdev() performs a NULL check before actually
> freeing the structure, so the "if (pnetdev)" check isn't really
> necessary before calling rtw_free_netdev().
> That's the reason why I removed that check.
>
That's not the question Greg and I asked. Re-read the emails.
regards,
dan carpenter
next prev parent reply other threads:[~2021-11-25 7:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 19:53 [PATCH] staging: r8188eu: remove unnecessary NULL check Vihas Mak
2021-11-22 21:22 ` Pavel Skripkin
2021-11-23 23:49 ` Vihas Mak
2021-11-23 8:06 ` Dan Carpenter
2021-11-24 10:00 ` Greg KH
2021-11-25 1:32 ` Vihas Mak
2021-11-25 7:09 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-24 8:03 [PATCH] staging: r8188eu: remove unnecessary null check cgel.zte
2022-08-25 6:36 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211125070914.GM6514@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=makvihas@gmail.com \
--cc=martin@kaiser.cx \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox