From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ngo Tak Fong <simon.fodin@gmail.com>
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8712: Fix alignment checks
Date: Mon, 6 Dec 2021 17:22:31 +0300 [thread overview]
Message-ID: <20211206142231.GB1956@kadam> (raw)
In-Reply-To: <20211206001949.GA54773@simon-desktop>
On Mon, Dec 06, 2021 at 08:19:49AM +0800, Ngo Tak Fong wrote:
> Fixed two CHECKs of Alignment should match open parenthesis.
>
> Signed-off-by: Ngo Tak Fong <simon.fodin@gmail.com>
> ---
> drivers/staging/rtl8712/rtl8712_efuse.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c
> index 4f3b54a7c3be..3555f612a066 100644
> --- a/drivers/staging/rtl8712/rtl8712_efuse.c
> +++ b/drivers/staging/rtl8712/rtl8712_efuse.c
> @@ -300,16 +300,15 @@ static u8 fix_header(struct _adapter *adapter, u8 header, u16 header_addr)
> for (i = 0; i < PGPKG_MAX_WORDS; i++) {
> if (BIT(i) & word_en) {
The real problem is this code is jammed up against the right hand side
of the screen. Just flip this condition around and pull the code in
one tab.
if (!(BIT(i) & word_en)
continue;
> if (BIT(i) & pkt.word_en) {
> - if (efuse_one_byte_read(
> - adapter, addr,
> - &value))
> + if (efuse_one_byte_read(adapter,
> + addr,
> + &value))
reards,
dan carpenter
prev parent reply other threads:[~2021-12-06 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 0:19 [PATCH] staging: rtl8712: Fix alignment checks Ngo Tak Fong
2021-12-06 14:22 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211206142231.GB1956@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=simon.fodin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox