From: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
To: gregkh@linuxfoundation.org, realwakka@gmail.com,
paulo.miguel.almeida.rodenas@gmail.com
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2] staging: pi433: add comment to rx_lock mutex definition
Date: Thu, 23 Dec 2021 10:56:15 +1300 [thread overview]
Message-ID: <20211222215615.GA9361@localhost.localdomain> (raw)
Checkpatch reports: CHECK: struct mutex definition without comment.
Fix this by documenting what rx_mutex struct is used for in pi433 driver.
Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
---
v2: ellaborate on reasons why the mutex lock is used in the driver (Req: Greg k-h)
v1: https://lore.kernel.org/lkml/20211222093626.GA13332@localhost.localdomain/
---
drivers/staging/pi433/pi433_if.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 29bd37669059..1cd3d5f2df2a 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -92,6 +92,17 @@ struct pi433_device {
u32 rx_bytes_to_drop;
u32 rx_bytes_dropped;
unsigned int rx_position;
+ /*
+ * rx_lock is used to avoid race-conditions that can be triggered from userspace.
+ *
+ * For instance, if a program in userspace is reading the char device
+ * allocated in this module then another program won't be able to change RX
+ * configuration of the RF69 hardware module via ioctl and vice versa.
+ *
+ * utilization summary:
+ * - pi433_read: blocks are read until rx read something (up to the buffer size)
+ * - pi433_ioctl: during pending read request, change of config not allowed
+ */
struct mutex rx_lock;
wait_queue_head_t rx_wait_queue;
--
2.25.4
next reply other threads:[~2021-12-22 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 21:56 Paulo Miguel Almeida [this message]
2021-12-30 10:56 ` [PATCH v2] staging: pi433: add comment to rx_lock mutex definition Greg KH
2021-12-30 14:56 ` Paulo Miguel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211222215615.GA9361@localhost.localdomain \
--to=paulo.miguel.almeida.rodenas@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=realwakka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox