Re: [PATCH v2] staging: vt6655: drop off byRxMode var in device.h

Greg Kroah-Hartman
2021-12-21T06:34:23Z

On Mon, Dec 20, 2021 at 09:25:20PM +0100, Tommaso Merciai wrote:
> Drop off unused variable byRxMode in device.h, this fix following
> checkpatch.pl check:
> CHECK: Avoid CamelCase: <byRxMode>
> 131: FILE: drivers/staging/vt6655/device.h:131:
> unsigned char byRxMode

No need to line-wrap this.

But this "problem" is not the real thing you are fixing. The real thing
is the issue that this variable is not needed at all. Just say that, no
need to justify it with a checkpatch warning, right?

thanks,

greg k-h