From: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: add docs to packet_format and tx_start_condition enum
Date: Fri, 31 Dec 2021 04:53:44 +1300 [thread overview]
Message-ID: <20211230155344.GA5404@localhost.localdomain> (raw)
In-Reply-To: <Yc2QrMecuVQFRcBZ@kroah.com>
On Thu, Dec 30, 2021 at 11:57:48AM +0100, Greg KH wrote:
> > +/*
> > + * Defines the packet format used.
>
> What "Defines"? This is an odd sentence.
Noted. I will change that.
> > + * In both modes the length of the payload is limited to 255 bytes if AES
> > + * is not enabled or 64 bytes otherwise.
>
> What does this have to do with the format type?
>
The rationale was that I wanted the developer to know straight away how
much info would be possible to transfer given the combination of
encryption + packet_format settings.
But now that you mentioned it, I can see that this info/obs could be
misplaced. I will remove it.
> > + /* at least one byte in the FIFO */
> > fifo_not_empty
> > };
>
> Also, always run your patches through scripts/checkpatch.pl before
> sending them out. I couldn't take this patch for that reason alone :(
>
My apologies, I will be extra careful next time.
thanks,
Paulo A.
prev parent reply other threads:[~2021-12-30 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 9:47 [PATCH] staging: pi433: add docs to packet_format and tx_start_condition enum Paulo Miguel Almeida
2021-12-30 10:57 ` Greg KH
2021-12-30 15:53 ` Paulo Miguel Almeida [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211230155344.GA5404@localhost.localdomain \
--to=paulo.miguel.almeida.rodenas@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox