From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH v2 1/7] staging: r8188eu: bRDGEnable is always false
Date: Sat, 1 Jan 2022 09:17:52 +0100 [thread overview]
Message-ID: <20220101081758.9716-2-straube.linux@gmail.com> (raw)
In-Reply-To: <20220101081758.9716-1-straube.linux@gmail.com>
The field bRDGEnable in struct hal_data_8188e is never set. It stays
at its default value 0. Remove bRDGEnable and related dead code.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
v2: no changes
drivers/staging/r8188eu/hal/usb_halinit.c | 10 ----------
drivers/staging/r8188eu/include/rtl8188e_hal.h | 3 ---
2 files changed, 13 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
index d5c7e8bf1f38..104705ef170e 100644
--- a/drivers/staging/r8188eu/hal/usb_halinit.c
+++ b/drivers/staging/r8188eu/hal/usb_halinit.c
@@ -384,13 +384,6 @@ static void _InitEDCA(struct adapter *Adapter)
rtw_write32(Adapter, REG_EDCA_VO_PARAM, 0x002FA226);
}
-static void _InitRDGSetting(struct adapter *Adapter)
-{
- rtw_write8(Adapter, REG_RD_CTRL, 0xFF);
- rtw_write16(Adapter, REG_RD_NAV_NXT, 0x200);
- rtw_write8(Adapter, REG_RD_RESP_PKT_TH, 0x05);
-}
-
static void _InitRetryFunction(struct adapter *Adapter)
{
u8 value8;
@@ -712,9 +705,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
value16 |= (MACTXEN | MACRXEN);
rtw_write8(Adapter, REG_CR, value16);
- if (haldata->bRDGEnable)
- _InitRDGSetting(Adapter);
-
/* Enable TX Report */
/* Enable Tx Report Timer */
value8 = rtw_read8(Adapter, REG_TX_RPT_CTRL);
diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
index b42af86555cd..e8cb093abb62 100644
--- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
+++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
@@ -236,9 +236,6 @@ struct hal_data_8188e {
u32 RfRegChnlVal[2];
- /* RDG enable */
- bool bRDGEnable;
-
/* for host message to fw */
u8 LastHMEBoxNum;
--
2.34.1
next prev parent reply other threads:[~2022-01-01 8:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-01 8:17 [PATCH v2 0/7] staging: r8188eu: clean up struct hal_data_8188e Michael Straube
2022-01-01 8:17 ` Michael Straube [this message]
2022-01-01 8:17 ` [PATCH v2 2/7] staging: r8188eu: UsbRxHighSpeedMode is set but never used Michael Straube
2022-01-01 8:17 ` [PATCH v2 3/7] staging: r8188eu: bTXPowerDataReadFromEEPORM " Michael Straube
2022-01-01 8:17 ` [PATCH v2 4/7] staging: r8188eu: bAPKThermalMeterIgnore " Michael Straube
2022-01-01 8:17 ` [PATCH v2 5/7] staging: r8188eu: remove unused fields from struct hal_data_8188e Michael Straube
2022-01-01 8:17 ` [PATCH v2 6/7] staging: r8188eu: IntArray and C2hArray are set but never used Michael Straube
2022-01-01 8:32 ` Michael Straube
2022-01-01 8:17 ` [PATCH v2 7/7] staging: r8188eu: FwRsvdPageStartOffset is " Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220101081758.9716-2-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).