From: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
To: Sidong Yang <realwakka@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: pi433: move get version func to where all other functions are
Date: Sun, 9 Jan 2022 10:02:19 +1300 [thread overview]
Message-ID: <20220108210219.GB3660@mail.google.com> (raw)
In-Reply-To: <20220108163621.GA26654@realwakka>
On Sat, Jan 08, 2022 at 04:36:21PM +0000, Sidong Yang wrote:
> On Sat, Jan 08, 2022 at 02:19:10PM +0300, Dan Carpenter wrote:
> >
> > Yes. Keep the error handling. Your way makes the code more complicated
> > to read.
>
> I totally really agree with it.
> Because the switch clause under this patch catches error with 'default:'
> but it returns '-ENODEV'. I worried that it lost retval from reading
> register if it has error.
>
I will add it back to the patch.
thanks,
Paulo A.
next prev parent reply other threads:[~2022-01-08 21:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 9:31 [PATCH] staging: pi433: move get version func to where all other functions are Paulo Miguel Almeida
2022-01-06 10:19 ` Sidong Yang
2022-01-06 20:14 ` Paulo Miguel Almeida
2022-01-06 21:33 ` [PATCH v2] " Paulo Miguel Almeida
2022-01-07 8:53 ` Dan Carpenter
2022-01-07 19:24 ` Paulo Miguel Almeida
2022-01-08 11:19 ` Dan Carpenter
2022-01-08 16:36 ` Sidong Yang
2022-01-08 21:02 ` Paulo Miguel Almeida [this message]
2022-01-08 20:59 ` Paulo Miguel Almeida
2022-01-08 21:27 ` [PATCH v3] " Paulo Miguel Almeida
2022-01-06 14:04 ` [PATCH] " Greg KH
2022-01-06 21:01 ` Paulo Miguel Almeida
2022-01-07 8:32 ` Dan Carpenter
2022-01-07 18:45 ` Paulo Miguel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220108210219.GB3660@mail.google.com \
--to=paulo.miguel.almeida.rodenas@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=realwakka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).