From: Abdun Nihaal <abdun.nihaal@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
straube.linux@gmail.com, martin@kaiser.cx,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] staging: r8188eu: remove unneeded ret variables
Date: Sat, 29 Jan 2022 15:50:04 +0530 [thread overview]
Message-ID: <20220129102004.im7dcq5gbuyqlw4o@nlap2> (raw)
In-Reply-To: <YfK/aOgEqftXuj1S@kroah.com>
On Thu, Jan 27, 2022 at 04:51:04PM +0100, Greg KH wrote:
> A single patch per function you are changing is a good idea. Do not mix
> them all together, would you want to review something like that?
>
> Always remember that you want to make changes obvious and simple to
> review.
Got it. I'll split the changes, as single patch per function.
Thanks,
Abdun Nihaal
next prev parent reply other threads:[~2022-01-29 10:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 10:35 [PATCH v3 0/2] staging: r8188eu: remove unneeded ret variables Abdun Nihaal
2022-01-07 10:35 ` [PATCH v3 1/2] " Abdun Nihaal
2022-01-25 15:10 ` Greg KH
2022-01-27 15:25 ` Abdun Nihaal
2022-01-27 15:51 ` Greg KH
2022-01-29 10:20 ` Abdun Nihaal [this message]
2022-01-07 10:35 ` [PATCH v3 2/2] staging: r8188eu: change functions to return void Abdun Nihaal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220129102004.im7dcq5gbuyqlw4o@nlap2 \
--to=abdun.nihaal@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox