From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joel Chang <joelcchangg@gmail.com>
Cc: Joe Perches <joe@perches.com>,
David Laight <David.Laight@aculab.com>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gregkh@linuxfoundation.com" <gregkh@linuxfoundation.com>
Subject: Re: [PATCH] staging: octeon-usb: Fix 'should not end with '(''
Date: Mon, 7 Feb 2022 11:09:35 +0300 [thread overview]
Message-ID: <20220207080935.GC1951@kadam> (raw)
In-Reply-To: <CAJ-=yTE7mZr_DtCE3HA4ruqexo1gH+LPCWzHAeSmivzj5H76Gg@mail.gmail.com>
On Mon, Feb 07, 2022 at 09:57:34AM +0800, Joel Chang wrote:
> The hunk has two lines that end with '('. The hunk was rewritten but I
> believe the logic remains the same.
>
> I agree they are longer than is 'nice', but they are still under 100 chars.
Just ignore checkpatch when it tempts you to make the code worse.
regards,
dan carpenter
prev parent reply other threads:[~2022-02-07 8:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 7:46 [PATCH] staging: octeon-usb: Fix 'should not end with '('' joelcchangg
2022-02-06 14:16 ` David Laight
2022-02-06 17:17 ` Joe Perches
2022-02-06 19:50 ` Joe Perches
2022-02-07 1:57 ` Joel Chang
2022-02-07 8:09 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220207080935.GC1951@kadam \
--to=dan.carpenter@oracle.com \
--cc=David.Laight@aculab.com \
--cc=gregkh@linuxfoundation.com \
--cc=joe@perches.com \
--cc=joelcchangg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).