Re: [PATCH v2 33/66] media: sun6i-csi: Rework register definitions, invert misleading fields

Maxime Ripard
2022-02-09T09:39:51Z

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

On Sat, Feb 05, 2022 at 07:53:56PM +0100, Paul Kocialkowski wrote:
> This cleans up the register definitions a bit, adds a prefix, remove masks.
> Registers are now fully defined, some additional fields were added when
> needed. New format definitions are added for future use.
>
> Some fields are wrongly defined (inverted) in Allwinner litterature
> (e.g. field vs frame prefixes), which is quite misleading. They are
> now corrected to reflect their actual behavior.

How was it tested?

In particular, see
https://lore.kernel.org/all/20180305093535.11801-7-maxime.ripard@bootlin.com/

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]