[PATCH 0/2] staging: r8188eu: two simple cleanups

[PATCH 0/2] staging: r8188eu: two simple cleanups

[Michael Straube]

This set removes an unused enum and unused constants from the enum
hw_variables.

Michael Straube (2):
  staging: r8188eu: remove unused enum
  staging: r8188eu: clean up enum hw_variables

 drivers/staging/r8188eu/hal/rtl8188e_hal_init.c |  8 --------
 drivers/staging/r8188eu/include/hal_intf.h      | 17 -----------------
 2 files changed, 25 deletions(-)

-- 
2.35.1

[PATCH 1/2] staging: r8188eu: remove unused enum

[Michael Straube]

Remove an unused enum from rtl8188e_hal_init.c.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
 drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
index b3ae358d1143..8fe74e21992e 100644
--- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
@@ -336,14 +336,6 @@ int rtl8188e_IOL_exec_cmds_sync(struct adapter *adapter, struct xmit_frame *xmit
 	return ret;
 }
 
-/*  */
-/*			Efuse related code */
-/*  */
-enum{
-		VOLTAGE_V25						= 0x03,
-		LDOE25_SHIFT						= 28,
-	};
-
 void rtl8188e_EfusePowerSwitch(struct adapter *pAdapter, u8 PwrState)
 {
 	u16	tmpV16;
-- 
2.35.1

[PATCH 2/2] staging: r8188eu: clean up enum hw_variables

[Michael Straube]

Remove unused constants from enum hw_variables.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
 drivers/staging/r8188eu/include/hal_intf.h | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/drivers/staging/r8188eu/include/hal_intf.h b/drivers/staging/r8188eu/include/hal_intf.h
index e8731e2668f6..8e204d61cc53 100644
--- a/drivers/staging/r8188eu/include/hal_intf.h
+++ b/drivers/staging/r8188eu/include/hal_intf.h
@@ -11,7 +11,6 @@
 enum hw_variables {
 	HW_VAR_SET_OPMODE,
 	HW_VAR_BSSID,
-	HW_VAR_INIT_RTS_RATE,
 	HW_VAR_BASIC_RATE,
 	HW_VAR_CORRECT_TSF,
 	HW_VAR_MLME_DISCONNECT,
@@ -25,7 +24,6 @@ enum hw_variables {
 	HW_VAR_DM_FUNC_OP,
 	HW_VAR_DM_FUNC_SET,
 	HW_VAR_DM_FUNC_CLR,
-	HW_VAR_CAM_READ,
 	HW_VAR_AC_PARAM_BE,
 	HW_VAR_ACM_CTRL,
 	HW_VAR_AMPDU_MIN_SPACE,
@@ -35,24 +33,9 @@ enum hw_variables {
 	HW_VAR_H2C_FW_JOINBSSRPT,
 	HW_VAR_FWLPS_RF_ON,
 	HW_VAR_H2C_FW_P2P_PS_OFFLOAD,
-	HW_VAR_TDLS_WRCR,
-	HW_VAR_TDLS_INIT_CH_SEN,
-	HW_VAR_TDLS_RS_RCR,
-	HW_VAR_TDLS_DONE_CH_SEN,
 	HW_VAR_INITIAL_GAIN,
-	HW_VAR_BT_SET_COEXIST,
-	HW_VAR_BT_ISSUE_DELBA,
-	HW_VAR_ANTENNA_DIVERSITY_LINK,
 	HW_VAR_ANTENNA_DIVERSITY_SELECT,
-	HW_VAR_SWITCH_EPHY_WoWLAN,
-	HW_VAR_EFUSE_USAGE,
-	HW_VAR_EFUSE_BT_USAGE,
-	HW_VAR_EFUSE_BT_BYTES,
 	HW_VAR_FIFO_CLEARN_UP,
-	/*  The valid upper nav range for the HW updating, if the true value is
-	 *  larger than the upper range, the HW won't update it. */
-	/*  Unit in microsecond. 0 means disable this function. */
-	HW_VAR_NAV_UPPER,
 	HW_VAR_RPT_TIMER_SETTING,
 	HW_VAR_TX_RPT_MAX_MACID,
 	HW_VAR_H2C_MEDIA_STATUS_RPT,
-- 
2.35.1

[PATCH 0/2] staging: r8188eu: two simple cleanups

[Michael Straube]

This series contains two simple cleanup patches.
Tested on x86_64 with Inter-Tech DMG-02.

Michael Straube (2):
  staging: r8188eu: remove extern from function prototypes
  staging: r8188eu: convert rtw_free_stainfo() to void

 drivers/staging/r8188eu/core/rtw_sta_mgt.c     |  8 ++------
 .../staging/r8188eu/include/osdep_service.h    |  2 +-
 drivers/staging/r8188eu/include/rtw_mlme_ext.h |  4 ++--
 drivers/staging/r8188eu/include/sta_info.h     | 18 +++++++++---------
 4 files changed, 14 insertions(+), 18 deletions(-)

-- 
2.38.0

Re: [PATCH 0/2] staging: r8188eu: two simple cleanups

[Philipp Hortmann]

On 11/1/22 20:14, Michael Straube wrote:
> This series contains two simple cleanup patches.
> Tested on x86_64 with Inter-Tech DMG-02.
> 
> Michael Straube (2):
>    staging: r8188eu: remove extern from function prototypes
>    staging: r8188eu: convert rtw_free_stainfo() to void
> 
>   drivers/staging/r8188eu/core/rtw_sta_mgt.c     |  8 ++------
>   .../staging/r8188eu/include/osdep_service.h    |  2 +-
>   drivers/staging/r8188eu/include/rtw_mlme_ext.h |  4 ++--
>   drivers/staging/r8188eu/include/sta_info.h     | 18 +++++++++---------
>   4 files changed, 14 insertions(+), 18 deletions(-)
> 

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150

[PATCH 0/2] staging: r8188eu: two simple cleanups

[Michael Straube]

This series contains two simple cleanups.

Tested on x86_64 with Inter-Tech DMG-02.

Michael Straube (2):
  staging: r8188eu: busetkipkey is boolean
  staging: r8188eu: bgrpkey_handshake is set but never used

 drivers/staging/r8188eu/core/rtw_mlme.c        | 1 -
 drivers/staging/r8188eu/core/rtw_recv.c        | 2 +-
 drivers/staging/r8188eu/core/rtw_xmit.c        | 2 +-
 drivers/staging/r8188eu/include/rtw_security.h | 1 -
 4 files changed, 2 insertions(+), 4 deletions(-)

-- 
2.39.2

Re: [PATCH 0/2] staging: r8188eu: two simple cleanups

[Philipp Hortmann]

On 3/7/23 09:50, Michael Straube wrote:
> This series contains two simple cleanups.
> 
> Tested on x86_64 with Inter-Tech DMG-02.
> 
> Michael Straube (2):
>    staging: r8188eu: busetkipkey is boolean
>    staging: r8188eu: bgrpkey_handshake is set but never used
> 
>   drivers/staging/r8188eu/core/rtw_mlme.c        | 1 -
>   drivers/staging/r8188eu/core/rtw_recv.c        | 2 +-
>   drivers/staging/r8188eu/core/rtw_xmit.c        | 2 +-
>   drivers/staging/r8188eu/include/rtw_security.h | 1 -
>   4 files changed, 2 insertions(+), 4 deletions(-)
> 

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150

Re: [PATCH 0/2] staging: r8188eu: two simple cleanups

[Greg KH]

On Tue, Mar 07, 2023 at 09:50:01AM +0100, Michael Straube wrote:
> This series contains two simple cleanups.
> 
> Tested on x86_64 with Inter-Tech DMG-02.
> 
> Michael Straube (2):
>   staging: r8188eu: busetkipkey is boolean
>   staging: r8188eu: bgrpkey_handshake is set but never used
> 
>  drivers/staging/r8188eu/core/rtw_mlme.c        | 1 -
>  drivers/staging/r8188eu/core/rtw_recv.c        | 2 +-
>  drivers/staging/r8188eu/core/rtw_xmit.c        | 2 +-
>  drivers/staging/r8188eu/include/rtw_security.h | 1 -
>  4 files changed, 2 insertions(+), 4 deletions(-)
> 
> -- 
> 2.39.2
> 
> 

Sorry, but I've now deleted this driver, so these patches do not apply.

greg k-h