From: Dan Carpenter <dan.carpenter@oracle.com>
To: Moses Christopher Bollavarapu <mosescb.dev@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: rtl8192e: use BIT macro instead of left shifting
Date: Fri, 18 Feb 2022 18:37:37 +0300 [thread overview]
Message-ID: <20220218153737.GJ2407@kadam> (raw)
In-Reply-To: <20220218162908.48f83564@cpi>
The subject needs to say "[PATCH] staging: rtl8192e:"
On Fri, Feb 18, 2022 at 04:29:08PM +0100, Moses Christopher Bollavarapu wrote:
> From eaca0dd8fcbe3ff6daf14ea7a532e53acf840790 Mon Sep 17 00:00:00 2001
> From: Moses Christopher Bollavarapu <mosescb.dev@gmail.com>
> Date: Fri, 18 Feb 2022 16:08:16 +0100
> Subject: [PATCH] drivers: staging: rtl8192e: use BIT macro instead of left shifting
^^^^^^^^
Leave out the drivers:
>
The patch looks okay but these headers do not belong.
regards,
dan carpenter
next prev parent reply other threads:[~2022-02-18 15:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 15:29 rtl8192e: use BIT macro instead of left shifting Moses Christopher Bollavarapu
2022-02-18 15:37 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-02-18 15:32 Moses Christopher Bollavarapu
2022-02-21 17:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218153737.GJ2407@kadam \
--to=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mosescb.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox