From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45354513D for ; Sun, 20 Feb 2022 10:02:22 +0000 (UTC) Received: by mail-ed1-f42.google.com with SMTP id m17so23348079edc.13 for ; Sun, 20 Feb 2022 02:02:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j2xZHeiG083yzKkuwwrfxDMOHMTEvS0BBe2aT8XTSjE=; b=hMWAPNYnvQO0lcnti8nUKnHcotk1QbkXffJrttbjhU0QA3s/lyGM003DzA2UBvGB3a 8ZVw1TtigbpjW3DT3EltENukaIMcvit5TKjh55hTAVgaXbHOrxrSiIGRxmZq3h4+ECMy ndfEUzSI4Fz6zG5A1KLhpWQIdO8ehQfW6nH0JkLQkZh68i+LAcapXps4N98PDk36bRsb splozHraOAcPsv+8nlKwsnJcr3NT4nQ3S7/05DlqWUKPK+mMs8Itl7e6pch3RB8CtdfQ YxpfJDMELoLBw8MwGRZtoAfEyxBhiO3r9TrC5f9w8B0vYb82qTho29ER9UF8EyOsa+/y etkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j2xZHeiG083yzKkuwwrfxDMOHMTEvS0BBe2aT8XTSjE=; b=UT/a1GWZaDb/lBoLws3vVHEpS5QQiNoGKfxVKIpjukmhrMw3wIl5DCiOO9uNw3f8Hh 2U46QCo6YH0djn4UVq4T2xCpRW5CEPaRppQIoz8iHP9uoT6JbSSTiYRkqoK/MPY9tbrZ rRZKKNKfHcmnKGioQiOcvi/i52e5b9M/E1ijrVhjfdZgLN3+R9CM7mBu1QEXF5rf0RhP uitWIPe7Wii20mv0FUp2UNnelC4DkmZuGefM89dXbOVrVOvYiG4HCRHOyUvwed21pUVD qfNFmY6/i7fQyDyaFSCD/v8OIyrHwWdrbUOXG1eRIO1R8o4rhAB/AQNREgVDFk7wVRtj VIOg== X-Gm-Message-State: AOAM5310Eh9rrxRWLQ3Sk/4L6wFD0iWK7YWVS0CXprbh2ljrkNeDHXGb 0sRKX0Cpf5EXXDnxNayd1SM= X-Google-Smtp-Source: ABdhPJzsB8+zYF+59/WpSNP/RSH7bKKUEtglBIWA5Bhy3x3nyt1rD4nxG82nO/B3HckRampxq8Y6oQ== X-Received: by 2002:aa7:d1d7:0:b0:410:d6cf:82b2 with SMTP id g23-20020aa7d1d7000000b00410d6cf82b2mr15799003edp.193.1645351340717; Sun, 20 Feb 2022 02:02:20 -0800 (PST) Received: from localhost.localdomain (ip5f5abb8f.dynamic.kabel-deutschland.de. [95.90.187.143]) by smtp.gmail.com with ESMTPSA id dx7sm3265223ejb.23.2022.02.20.02.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 02:02:20 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 2/5] staging: r8188eu: convert two u8 variables to bool Date: Sun, 20 Feb 2022 11:02:09 +0100 Message-Id: <20220220100212.7466-3-straube.linux@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220220100212.7466-1-straube.linux@gmail.com> References: <20220220100212.7466-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The variables bScanInProcess in struct mlme_priv and bpower_saving in struct pwrctrl_priv are both unsed to store only boolean values true and false. Convert them from u8 to bool to avoid type casts in the function Update_ODM_ComInfo_88E(). Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/rtl8188e_dm.c | 4 ++-- drivers/staging/r8188eu/include/rtw_mlme.h | 2 +- drivers/staging/r8188eu/include/rtw_pwrctrl.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_dm.c b/drivers/staging/r8188eu/hal/rtl8188e_dm.c index 09e78c4855f9..082104c9b2e8 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_dm.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_dm.c @@ -42,8 +42,8 @@ static void Update_ODM_ComInfo_88E(struct adapter *Adapter) dm_odm->pSecChOffset = &hal_data->nCur40MhzPrimeSC; dm_odm->pBandWidth = (u8 *)&hal_data->CurrentChannelBW; dm_odm->pChannel = &hal_data->CurrentChannel; - dm_odm->pbScanInProcess = (bool *)&pmlmepriv->bScanInProcess; - dm_odm->pbPowerSaving = (bool *)&pwrctrlpriv->bpower_saving; + dm_odm->pbScanInProcess = &pmlmepriv->bScanInProcess; + dm_odm->pbPowerSaving = &pwrctrlpriv->bpower_saving; ODM_CmnInfoInit(dm_odm, ODM_CMNINFO_RF_ANTENNA_TYPE, hal_data->TRxAntDivType); diff --git a/drivers/staging/r8188eu/include/rtw_mlme.h b/drivers/staging/r8188eu/include/rtw_mlme.h index 1e16fa615b94..d418d57f99b6 100644 --- a/drivers/staging/r8188eu/include/rtw_mlme.h +++ b/drivers/staging/r8188eu/include/rtw_mlme.h @@ -310,7 +310,7 @@ struct qos_priv { struct mlme_priv { spinlock_t lock; int fw_state; /* shall we protect this variable? maybe not necessarily... */ - u8 bScanInProcess; + bool bScanInProcess; u8 to_join; /* flag */ u8 to_roaming; /* roaming trying times */ diff --git a/drivers/staging/r8188eu/include/rtw_pwrctrl.h b/drivers/staging/r8188eu/include/rtw_pwrctrl.h index 2d5298373d74..7c3cb895c3cd 100644 --- a/drivers/staging/r8188eu/include/rtw_pwrctrl.h +++ b/drivers/staging/r8188eu/include/rtw_pwrctrl.h @@ -49,7 +49,7 @@ struct pwrctrl_priv { u32 alives; struct work_struct cpwm_event; - u8 bpower_saving; + bool bpower_saving; u8 reg_rfoff; u8 reg_pdnmode; /* powerdown mode */ -- 2.35.1