From: Dan Carpenter <dan.carpenter@oracle.com>
To: Michael Straube <straube.linux@gmail.com>
Cc: Pavel Skripkin <paskripkin@gmail.com>,
gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: r8188eu: refactor rtw_ch2freq()
Date: Tue, 22 Feb 2022 08:34:52 +0300 [thread overview]
Message-ID: <20220222053452.GC3943@kadam> (raw)
In-Reply-To: <32a2b74b-f541-ddf6-d8c9-6bd6ca0ad07b@gmail.com>
On Mon, Feb 21, 2022 at 08:20:14PM +0100, Michael Straube wrote:
> On 2/21/22 13:22, Dan Carpenter wrote:
> > On Sun, Feb 20, 2022 at 05:30:08PM +0100, Michael Straube wrote:
> > > On 2/20/22 17:20, Pavel Skripkin wrote:
> > Just from a review stand point it would be best to leave the original
> > behavior.
> >
>
> Do you mean to leave the whole original code including the 5 GHz
> frequencies? Or returning a default value if we have a channel value < 1
> or > 14?
I meant what Pavel said:
if (channel == 0 || channel > ARRAY_SIZE(ch_freq_map))
return 2412;
return ch_freq_map[channel - 1];
>
> I'm a bit confused now, because Greg asked how we know that the driver
> is only for 2.4 GHz chips.
>
Haven't you been deleting all the 5GHz code for some time now? Greg
isn't saying you have to keep that if there is no reason. Just put the
reason in the commit message and resend.
regards,
dan carpenter
next prev parent reply other threads:[~2022-02-22 5:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 15:48 [PATCH 0/3] staging: r8188eu: clean up rtw_rf.c Michael Straube
2022-02-20 15:48 ` [PATCH 1/3] staging: r8188eu: remove 5 GHz channels from ch_freq_map Michael Straube
2022-02-21 17:13 ` Greg KH
2022-02-21 19:07 ` Michael Straube
2022-02-21 19:41 ` Larry Finger
2022-02-25 8:57 ` Greg KH
2022-02-20 15:48 ` [PATCH 2/3] staging: r8188eu: refactor rtw_ch2freq() Michael Straube
2022-02-20 16:20 ` Pavel Skripkin
2022-02-20 16:30 ` Michael Straube
2022-02-21 12:22 ` Dan Carpenter
2022-02-21 19:20 ` Michael Straube
2022-02-21 20:54 ` Pavel Skripkin
2022-02-22 5:40 ` Dan Carpenter
2022-02-22 5:34 ` Dan Carpenter [this message]
2022-02-20 15:48 ` [PATCH 3/3] staging: r8188eu: clean up rtw_rf.c Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222053452.GC3943@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).