linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vihas Makwana <makvihas@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Phillip Potter <phil@philpotter.co.uk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Michael Straube <straube.linux@gmail.com>,
	Martin Kaiser <martin@kaiser.cx>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/16] staging: r8188eu: convert functions to return bool
Date: Thu, 3 Mar 2022 15:20:03 +0300	[thread overview]
Message-ID: <20220303122003.GG2794@kadam> (raw)
In-Reply-To: <20220302204737.49056-1-makvihas@gmail.com>

On Thu, Mar 03, 2022 at 02:17:21AM +0530, Vihas Makwana wrote:
> There are many functions which return true/false but are marked as int, 
> uint, s32 etc. Mark them as bool.
> 
> Vihas Makwana (16):
>   staging: r8188eu: mark rtw_is_cckrates_included as bool
>   staging: r8188eu: mark rtw_is_cckratesonly_included as bool
>   staging: r8188eu: mark rtw_is_desired_network as bool
>   staging: r8188eu: mark PS_RDY_CHECK as bool
>   staging: r8188eu: mark check_indicate_seq as bool
>   staging: r8188eu: mark enqueue_reorder_recvframe as bool
>   staging: r8188eu: mark recv_indicatepkts_in_order as bool
>   staging: r8188eu: mark cckrates_included as bool
>   staging: r8188eu: mark cckratesonly_included as bool
>   staging: r8188eu: mark is_basicrate as bool
>   staging: r8188eu: mark is_ap_in_tkip as bool
>   staging: r8188eu: mark rtl8188eu_xmitframe_complete as bool
>   staging: r8188eu: mark check_fwstate as bool
>   staging: r8188eu: mark IS_MCAST as bool
>   staging: r8188eu: mark IsFrameTypeCtrl as bool
>   staging: r8188eu: mark rtw_endofpktfile as bool
> 

Looks good.  Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter


      parent reply	other threads:[~2022-03-03 12:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-02 20:47 [PATCH 00/16] staging: r8188eu: convert functions to return bool Vihas Makwana
2022-03-02 20:47 ` [PATCH 01/16] staging: r8188eu: mark rtw_is_cckrates_included as bool Vihas Makwana
2022-03-02 20:47 ` [PATCH 02/16] staging: r8188eu: mark rtw_is_cckratesonly_included " Vihas Makwana
2022-03-02 20:47 ` [PATCH 03/16] staging: r8188eu: mark rtw_is_desired_network " Vihas Makwana
2022-03-02 20:47 ` [PATCH 04/16] staging: r8188eu: mark PS_RDY_CHECK " Vihas Makwana
2022-03-02 20:47 ` [PATCH 05/16] staging: r8188eu: mark check_indicate_seq " Vihas Makwana
2022-03-02 20:47 ` [PATCH 06/16] staging: r8188eu: mark enqueue_reorder_recvframe " Vihas Makwana
2022-03-02 20:47 ` [PATCH 07/16] staging: r8188eu: mark recv_indicatepkts_in_order " Vihas Makwana
2022-03-02 20:47 ` [PATCH 08/16] staging: r8188eu: mark cckrates_included " Vihas Makwana
2022-03-02 20:47 ` [PATCH 09/16] staging: r8188eu: mark cckratesonly_included " Vihas Makwana
2022-03-02 20:47 ` [PATCH 10/16] staging: r8188eu: mark is_basicrate " Vihas Makwana
2022-03-02 20:47 ` [PATCH 11/16] staging: r8188eu: mark is_ap_in_tkip " Vihas Makwana
2022-03-02 20:47 ` [PATCH 12/16] staging: r8188eu: mark rtl8188eu_xmitframe_complete " Vihas Makwana
2022-03-02 20:47 ` [PATCH 13/16] staging: r8188eu: mark check_fwstate " Vihas Makwana
2022-03-02 20:47 ` [PATCH 14/16] staging: r8188eu: mark IS_MCAST " Vihas Makwana
2022-03-02 20:47 ` [PATCH 15/16] staging: r8188eu: mark IsFrameTypeCtrl " Vihas Makwana
2022-03-02 20:47 ` [PATCH 16/16] staging: r8188eu: mark rtw_endofpktfile " Vihas Makwana
2022-03-03 12:20 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220303122003.GG2794@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=makvihas@gmail.com \
    --cc=martin@kaiser.cx \
    --cc=phil@philpotter.co.uk \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).